Number concentration bug and code clean up in GFS_suite_interstitial_4#26
Merged
Merged
Conversation
2. Bug fix in liquid precipitation and frozen fraction - SRFLAG. This bug was producing 1.e-3 factor maller values of SRFLAG. 3. Modification to comment for precipitation in sfc_drv_ruc.F90
"to include GF updates in GSDv0beta4"
Some clean-up in sfc_drv_ruc.F90.
Sync RUC LSM code with the version used in RAP/HRRR
use of MYNN PBL. The problem: the first call to the radiation happens before the first call to MYNN PBL, therefore CLDFRA_BL=0 in the first call to mynnrad_pre, and zero values are sent to array cldcov(:,:). When cloud cover is zero, the RRTMG radiation thinks that there are no clouds at all. The erroneous cloud-free LW and SW downward radiation fluxes affect the first hour of itegration, and cause siginificant cooling in the ploar regions, and too warm land surface temperature from cloud-free SW radiation. The fix: the fist call to mynnrad_pre should be skipped, so that cloud cover - cldcov(:,:) - is not overwritten by zero values of MYNN subgrid-clouds. In this case the initial cloud cover is computed in progcld5 from initial cloud water mixing ratio, relative humidity and specific humidity in the layer. Starting with the second call to the rrtmg radiation, the MYNN subgrid clouds are used.
This commit has a fix for a problem of cloud-radiation coupling with the use of MYNN PBL.
…C LSM. Variables xlaixy and rdlai are added to the argument list of lsm_ruc_run. If rdlai=.true. in the physics namelist, then the LAI climatology will be passed into the RUC LSM and used instead of look-up table value for a given vegetation type.
Added the capability to use climatological LAI in RUC LSM
climbfuji
suggested changes
May 11, 2020
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the argument list and fixing those bugs. This will change the answer for all tests that use Thompson MP, right?
| gq0, clw, prsl, save_tcp, con_rd, nwfa, spechum, dqdti, imfdeepcnv, imfdeepcnv_gf, errmsg, errflg) | ||
| ntrw, ntsw, ntrnc, ntsnc, ntgl, ntgnc, ntlnc, ntinc, nn, imp_physics, imp_physics_gfdl, imp_physics_thompson, & | ||
| imp_physics_zhao_carr, imp_physics_zhao_carr_pdf, dtf, save_qc, save_qi, con_pi, & | ||
| gq0, clw, dqdti, errmsg, errflg) |
There was a problem hiding this comment.
If you remove these variables, please make sure to also remove them from the metadata file.
|
Associated PRs: For regression testing information, see NOAA-GSL/ufs-weather-model#21. |
DomHeinzeller
approved these changes
May 12, 2020
zhanglikate
referenced
this pull request
in zhanglikate/ccpp-physics
Mar 1, 2024
Add CLM Lake Model and update Flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a correction for a bug. I also removed some variables that are no longer used in the code. The amount of code changed is very minimal.