Skip to content

Number concentration bug and code clean up in GFS_suite_interstitial_4 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DomHeinzeller merged 25 commits into from
May 13, 2020
Merged

Number concentration bug and code clean up in GFS_suite_interstitial_4 #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
14c1c5b
"to include GF updates in GSDv0beta4"
haiqinli Sep 27, 2019
4ca463c
"update input of imfdeepcnv following Dom's suggestions"
haiqinli Oct 13, 2019
a59d416
"clean the code"
haiqinli Oct 13, 2019
fa3c1d3
1. Use fraction of frozen precipitation SR directly from Thompson MP.
tanyasmirnova Oct 17, 2019
0711b82
"update to pass ccpp_gsd regression test"
haiqinli Oct 20, 2019
3a28055
"update to pass the ccpp_gsd_noah_repro regression test case"
haiqinli Oct 23, 2019
4a17324
Merge pull request #338 from haiqinli/gsd/develop-hli
climbfuji Oct 24, 2019
27eb089
Merge branch 'gsd/develop' of https://github.com/NCAR/ccpp-physics in…
tanyasmirnova Oct 24, 2019
db9742d
Sync the RUC LSM code with the version in RAPv5/HRRRv4.
tanyasmirnova Oct 24, 2019
660ede7
Merge pull request #344 from tanyasmirnova/ruc_land_ice_v1
climbfuji Oct 28, 2019
e4d291e
This commit has a fix for a problem of cloud-radiation coupling with the
tanyasmirnova Nov 1, 2019
e0d5f16
Merge pull request #349 from tanyasmirnova/ruc_land_ice_v1
climbfuji Nov 1, 2019
bd32702
Added the capability to use a Leaf Area Index (LAI) climatology in RU…
tanyasmirnova Nov 20, 2019
b492f2e
Merge branch 'gsd/develop' of https://github.com/NCAR/ccpp-physics in…
tanyasmirnova Nov 20, 2019
7f530ed
Merge pull request #356 from tanyasmirnova/ruc_land_ice_v1
climbfuji Nov 21, 2019
3280060
Number concentration bug fix
hannahcbarnes May 8, 2020
c94592a
Merge branch 'gsd/develop' of https://github.com/hannahcbarnes/ccpp-p…
hannahcbarnes May 8, 2020
80fc439
Fix errors generated when did last pull request
hannahcbarnes May 8, 2020
2770c5c
Code clean up
hannahcbarnes May 8, 2020
0a418d4
Code cleanup
hannahcbarnes May 8, 2020
676e757
Code cleanup
hannahcbarnes May 8, 2020
44fdf26
Merge branch 'gsd/develop' of https://github.com/NOAA-GSD/ccpp-physic…
hannahcbarnes May 12, 2020
0f1e0ed
Clean up code
hannahcbarnes May 12, 2020
f5f6d12
Fix error
hannahcbarnes May 12, 2020
dc1c3ca
Clean code
hannahcbarnes May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions physics/GFS_suite_interstitial.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ end subroutine GFS_suite_interstitial_4_finalize
subroutine GFS_suite_interstitial_4_run (im, levs, ltaerosol, cplchm, tracers_total, ntrac, ntcw, ntiw, ntclamt, &
ntrw, ntsw, ntrnc, ntsnc, ntgl, ntgnc, ntlnc, ntinc, nn, imp_physics, imp_physics_gfdl, imp_physics_thompson, &
imp_physics_zhao_carr, imp_physics_zhao_carr_pdf, dtf, save_qc, save_qi, con_pi, &
gq0, clw, prsl, save_tcp, con_rd, nwfa, spechum, dqdti, imfdeepcnv, imfdeepcnv_gf, errmsg, errflg)
gq0, clw, prsl, save_tcp, con_rd, nwfa, spechum, dqdti, errmsg, errflg)

use machine, only: kind_phys
use module_mp_thompson_make_number_concentrations, only: make_IceNumber, make_DropletNumber
Expand All @@ -643,7 +643,7 @@ subroutine GFS_suite_interstitial_4_run (im, levs, ltaerosol, cplchm, tracers_to

integer, intent(in) :: im, levs, tracers_total, ntrac, ntcw, ntiw, ntclamt, ntrw, &
ntsw, ntrnc, ntsnc, ntgl, ntgnc, ntlnc, ntinc, nn, imp_physics, imp_physics_gfdl, imp_physics_thompson, &
imp_physics_zhao_carr, imp_physics_zhao_carr_pdf, imfdeepcnv, imfdeepcnv_gf
imp_physics_zhao_carr, imp_physics_zhao_carr_pdf

logical, intent(in) :: ltaerosol, cplchm

Expand Down Expand Up @@ -725,7 +725,7 @@ subroutine GFS_suite_interstitial_4_run (im, levs, ltaerosol, cplchm, tracers_to
qv_mp(i,k) = spechum(i,k)/(1.0_kind_phys-spechum(i,k))
if (ntlnc>0) then
!> - Convert moist mixing ratio to dry mixing ratio
qc_mp(i,k) = save_qc(i,k)/(1.0_kind_phys-spechum(i,k))
qc_mp(i,k) = (clw(i,k,2)-save_qc(i,k))/(1.0_kind_phys-spechum(i,k))
!> - Convert number concentration from moist to dry
nc_mp(i,k) = gq0(i,k,ntlnc)/(1.0_kind_phys-spechum(i,k))
nc_mp(i,k) = nc_mp(i,k) + max(0.0, make_DropletNumber(qc_mp(i,k) * rho_dryair(i,k), nwfa(i,k)) * (1.0/rho_dryair(i,k)))
Expand All @@ -734,7 +734,7 @@ subroutine GFS_suite_interstitial_4_run (im, levs, ltaerosol, cplchm, tracers_to
endif
if (ntinc>0) then
!> - Convert moist mixing ratio to dry mixing ratio
qi_mp(i,k) = save_qi(i,k)/(1.0_kind_phys-spechum(i,k))
qi_mp(i,k) = (clw(i,k,1)-save_qi(i,k))/(1.0_kind_phys-spechum(i,k))
!> - Convert number concentration from moist to dry
ni_mp(i,k) = gq0(i,k,ntinc)/(1.0_kind_phys-spechum(i,k))
ni_mp(i,k) = ni_mp(i,k) + max(0.0, make_IceNumber(qi_mp(i,k) * rho_dryair(i,k), save_tcp(i,k)) * (1.0/rho_dryair(i,k)))
Expand Down
16 changes: 0 additions & 16 deletions physics/GFS_suite_interstitial.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,22 +1764,6 @@
kind = kind_phys
intent = inout
optional = F
[imfdeepcnv]
standard_name = flag_for_mass_flux_deep_convection_scheme
long_name = flag for mass-flux deep convection scheme
units = flag
dimensions = ()
type = integer
intent = in
optional = F
[imfdeepcnv_gf]
standard_name = flag_for_gf_deep_convection_scheme
long_name = flag for Grell-Freitas deep convection scheme
units = flag
dimensions = ()
type = integer
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down