Bug fixes for/update of "Changes in cloud/radiation interaction in GSD physics suite", bug fixes for non-aerosol-aware Thompson MP#16
Merged
DomHeinzeller merged 9 commits intoMar 13, 2020
Conversation
Thompson MP, MYNN pbl and GF convection:
1. Switch the order of calls, first MYNNrad_pre (or SGSCloud_RadPre),
then rrtmg_pre. This will add sub-grid clouds from MYNN PBL (or MYNN PBL and GF)
to QC and QI, and these updated hydrometeors will be used to compute cloud paths
and effective radii.
2. In rrtmg_pre with the use of THompson MP:
- use Thompson's subroutines make_IceNumber and make_DropletNumber
to compute number concentrations for subgrid clouds.
- use calc_effectRad to compute effective radii for QC and QI
with sub-grid clouds.
- added option (clduni) to use the same subroutine to compute
water paths as with the GFDL MP. For this input.nl should set
effr_in=.true.
- the progcld5 is used mostly to compute Xu-Randall cloud
fraction.
3. Added *SGSCloud_* modules to replace *MYNNrad* to add all subgrid
clouds to QC and QI (from MYNN PBL and GF conv).
4. Added convective clouds qci_conv to GF scheme and SGSCloud_RadPre.
5. Computation of total cloud fraction in progcld5 is change not to
depend on shallow/deep convection. Not needed in the current version of
GSD suite.
2. Bug fix for the case when GF scheme is used without MYNN. In this case always use Xu-Randall cloud fraction.
this subroutine as the qgrs entries. Results before/after this change are identical.
…p-physics into HEAD, apply several bugfixes for radiation-cloud interaction and for non-aerosol-aware Thompson MP
…n array for Thompson MP
This was referenced Feb 21, 2020
tanyasmirnova
approved these changes
Feb 21, 2020
tanyasmirnova
left a comment
tanyasmirnova
left a comment
There was a problem hiding this comment.
Dom,
Thank you very much for fixing all the bugs in this PR.
Tanya
Author
|
Thanks for looking at the changes! I am not going to merge them now. Instead, I would like to ask @hannahcbarnes and/or @haiqinli to check out this code and run our usual set of 10 test cases for comparison against our baseline: |
Collaborator
|
@climbfuji Sure, we will do the retro runs and verification. Thanks. |
Author
|
Thanks, @haiqinli ! |
…ion; array qci_conv may not be allocated, thus use assumed-size declaration
DomHeinzeller
approved these changes
Mar 13, 2020
tanyasmirnova
pushed a commit
to tanyasmirnova/ccpp-physics
that referenced
this pull request
May 13, 2021
…path Update Cmakelists.txt so that it works with symlinks in compile path
christinaholtNOAA
pushed a commit
that referenced
this pull request
Mar 2, 2023
Adjust GFS diagnostic Aerosol Optical Depth (AOD) output to the exact 550nm
zhanglikate
referenced
this pull request
in zhanglikate/ccpp-physics
Apr 5, 2024
correctly convert from flashes per five minutes to flashes per minute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
mynnrad_{pre,post}schemes (superseded bysgscloud_{pre,post})Associated PRs:
#16
NOAA-GSL/fv3atm#13
NOAA-GSL/ufs-weather-model#11
See NOAA-GSL/ufs-weather-model#11 for regression testing information.