Namelist Refactor#58
Closed
jjuyeonkim wants to merge 10 commits into
Closed
Conversation
- Removing NamelistDefaults in the physics config - Updating to use simplified ndsl.Namelist - Replacing namelist with config for TranslatePhysicsFortranData2Py - Modifying workflow tests until namelist refactor is completed
8 tasks
fmalatino
requested review from
FlorianDeconinck,
fmalatino and
oelbert
and removed request for
FlorianDeconinck
fmalatino
reviewed
Sep 12, 2025
oelbert
requested changes
Sep 15, 2025
oelbert
left a comment
oelbert
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, a couple of stylistic changes for now and one group that should be a default.
| nwat: int = DEFAULT_INT | ||
| schemes: List = None | ||
| do_qa: bool = DEFAULT_BOOL | ||
| c_cracw: float = NamelistDefaults.c_cracw |
Collaborator
There was a problem hiding this comment.
It may be good to have these live in a local pyshield namelist defaults class but that's a discussion to have with NASA about code layout
Simplfying checkouts in translate tests for temporary jjuyeonkim fork workflows
…tching from_namelist/from_f90nml implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is one of multiple PRs to refactor the NDSL's
NamelistandNamelistDefaultsso that submodules have more ownership over configuration parameters and corresponding default values. NDSL Issue#64Changes include the following:
NamelistDefaultsin the physics config. Instead, the config class will store the default values directly.ndsl.NamelistnamelistwithconfiginTranslatePhysicsFixes: NOAA-GFDL/NDSL#64 (refactor that affects Pace, NDSL, PyFV3, and PySHiELD).
How Has This Been Tested?
PyFV3 and PySHiELD translate tests run as expected compared to the
developbranch. Pace unit tests also pass as expected.Checklist: