Namelist Refactor#145
Closed
jjuyeonkim wants to merge 14 commits into
Closed
Conversation
- Adding simple dycore tests from yaml and nml files - baroclinic_instability cleanup - Temporarily pointing to jjuyeonkim fork to pass CI, to be reverted after resolving issue NOAA-GFDL#64
Temporarily modifying main ci tests to checkout submodules with the 20250908_namelist_2 branch
fmalatino
approved these changes
Sep 12, 2025
fmalatino
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is one of multiple PRs to refactor the NDSL's
NamelistandNamelistDefaultsso that submodules have more ownership over configuration parameters and corresponding default values. NDSL Issue#64Changes include the following:
Fixes: NOAA-GFDL/NDSL#64 (refactor that affects Pace, NDSL, PyFV3, and PySHiELD).
How Has This Been Tested?
PyFV3 and PySHiELD translate tests run as expected compared to the
developbranch. Pace unit tests also pass as expected. Two simple unit tests have been added for checking that the dycore config loads correctly from bothinput.nmland*.yamlconfig.Checklist: