Skip to content

Namelist Refactor#145

Closed
jjuyeonkim wants to merge 14 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20250908_namelist_2
Closed

Namelist Refactor#145
jjuyeonkim wants to merge 14 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20250908_namelist_2

Conversation

@jjuyeonkim

@jjuyeonkim jjuyeonkim commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

Description
This is one of multiple PRs to refactor the NDSL's Namelistand NamelistDefaults so that submodules have more ownership over configuration parameters and corresponding default values. NDSL Issue#64

Changes include the following:

  • Adds simple dycore tests from yaml and nml files to help test the modified ndsl.Namelist
  • A small 'baroclinic_instability' cleanup in tests/main/fv3core/test_init_from_geos.py
  • Temporarily points to jjuyeonkim fork to pass CI, to be reverted after resolving NDSL issue #64

Fixes: NOAA-GFDL/NDSL#64 (refactor that affects Pace, NDSL, PyFV3, and PySHiELD).

How Has This Been Tested?
PyFV3 and PySHiELD translate tests run as expected compared to the develop branch. Pace unit tests also pass as expected. Two simple unit tests have been added for checking that the dycore config loads correctly from both input.nml and *.yaml config.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules -- There are changes in Pace, NDSL, PyFV3, and PySHiELD to address this issue. They need to be checked in together.
  • New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

jjuyeonkim and others added 8 commits September 9, 2025 11:53
- Adding simple dycore tests from yaml and nml files
- baroclinic_instability cleanup
- Temporarily pointing to jjuyeonkim fork to pass CI, to be reverted after resolving issue NOAA-GFDL#64
Temporarily modifying main ci tests to checkout submodules with the 20250908_namelist_2 branch
@jjuyeonkim jjuyeonkim marked this pull request as ready for review September 16, 2025 21:16
@jjuyeonkim jjuyeonkim closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NDSL should provide a framweork for physics namelists instead of specifying the namlist members and default values for specific physics models

2 participants