Skip to content

ci: Remove PACE_TEST_N_THRESHOLD_SAMPLES in translate tests#61

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/remove-pace-test-n-threshold-samples
May 30, 2025
Merged

ci: Remove PACE_TEST_N_THRESHOLD_SAMPLES in translate tests#61
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/remove-pace-test-n-threshold-samples

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented May 30, 2025

Description

Don't set PACE_TEST_N_THRESHOLD_SAMPLES in translate tests anymore since the environment variable was renamed in PR NOAA-GFDL/NDSL#134 and the default changed to match the currently configured behavior.

Now that develop of PyFV3 tracks develop of NDSL, we can do this change without waiting for a release of NDSL (which is incoming anyway).

How Has This Been Tested?

By running the CI.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

Don't set `PACE_TEST_N_THRESHOLD_SAMPLES` in translate tests anymore
since the environment variable was renamed in PR
NOAA-GFDL/NDSL#134 and the default changed to
match the currently configured behavior.
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented May 30, 2025

@FlorianDeconinck / @fmalatino pinging you here since I don't have the rights to assign reviewers in the PyFV3 repo.

@romanc romanc changed the title ci: Remove PACE_TEST_N_THRESHOLD_SAMPLES ci: Remove PACE_TEST_N_THRESHOLD_SAMPLES in translate tests May 30, 2025
@romanc romanc mentioned this pull request May 21, 2025
4 tasks
@FlorianDeconinck FlorianDeconinck self-requested a review May 30, 2025 12:10
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@bensonr bensonr requested a review from fmalatino May 30, 2025 13:07
@FlorianDeconinck FlorianDeconinck merged commit addcdce into NOAA-GFDL:develop May 30, 2025
4 checks passed
@romanc romanc deleted the romanc/remove-pace-test-n-threshold-samples branch May 30, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants