ci: Remove PACE_TEST_N_THRESHOLD_SAMPLES in translate tests#61
Merged
FlorianDeconinck merged 1 commit intoMay 30, 2025
Conversation
Don't set `PACE_TEST_N_THRESHOLD_SAMPLES` in translate tests anymore since the environment variable was renamed in PR NOAA-GFDL/NDSL#134 and the default changed to match the currently configured behavior.
Collaborator
Author
|
@FlorianDeconinck / @fmalatino pinging you here since I don't have the rights to assign reviewers in the PyFV3 repo. |
PACE_TEST_N_THRESHOLD_SAMPLES in translate tests
4 tasks
fmalatino
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't set
PACE_TEST_N_THRESHOLD_SAMPLESin translate tests anymore since the environment variable was renamed in PR NOAA-GFDL/NDSL#134 and the default changed to match the currently configured behavior.Now that
developofPyFV3tracksdevelopofNDSL, we can do this change without waiting for a release ofNDSL(which is incoming anyway).How Has This Been Tested?
By running the CI.
Checklist: