Translate tests: no threshold analysis by default#134
Merged
Conversation
- fix typos - capitalize words at the start of a sentence - add point a point at the end of a sentence
Currently, when translate tests fail, we run 10 (by default) times the same translate test/savepoint again with slightly perturbed inputs. The outputs are then analyzed to give developers an indication on whether errors that they are seeing are in the expected range of "noise propagation" or if this is more likely to be an error in porting.
romanc
changed the title
FlorianDeconinck
requested changes
Apr 17, 2025
4 tasks
romanc
added a commit
to romanc/PyFV3
that referenced
this pull request
May 30, 2025
Don't set `PACE_TEST_N_THRESHOLD_SAMPLES` in translate tests anymore since the environment variable was renamed in PR NOAA-GFDL/NDSL#134 and the default changed to match the currently configured behavior.
8 tasks
romanc
added a commit
to romanc/PySHiELD
that referenced
this pull request
May 30, 2025
Don't set `PACE_TEST_N_THRESHOLD_SAMPLES` in translate tests anymore since the environment variable was renamed in PR NOAA-GFDL/NDSL#134 and the default changed to match the currently configured behavior.
8 tasks
gmao-ckung
pushed a commit
to gmao-ckung/PyFV3
that referenced
this pull request
Jul 16, 2025
Don't set `PACE_TEST_N_THRESHOLD_SAMPLES` in translate tests anymore since the environment variable was renamed in PR NOAA-GFDL/NDSL#134 and the default changed to match the currently configured behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when translate tests fail, we run 10 (by default) times the same translate test/savepoint again with slightly perturbed inputs. The outputs are then analyzed to give developers an indication on whether errors that they are seeing are in the expected range of "noise propagation" or if this is more likely to be an error in porting.
This goes back to ai2cm/pace#222, which was never finished. Issue #133 was created to re-evaluate that system.
How Has This Been Tested?
Tested locally by setting the environment variable to 0.
Checklist: