Skip to content

refactor: replace NullComm with LocalComm#116

Merged
jjuyeonkim merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/replace-null-comm
Jan 16, 2026
Merged

refactor: replace NullComm with LocalComm#116
jjuyeonkim merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/replace-null-comm

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Jan 16, 2026

Description

Replace NullComm with LocalComm in pyFV3 since NullComm was deprecated in NDSL version 2025.11.00 in favor LocalComm. See NOAA-GFDL/NDSL#318 for context.

/cc @FlorianDeconinck

How Has This Been Tested?

All good as long as CI is still happy.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

Replace `NullComm` with `LocalComm` in pyFV3 since `NullComm` was
deprecated in `NDSL` version 2025.11.00 in favor `LocalComm`.

See NOAA-GFDL/NDSL#318 for context.
@romanc romanc marked this pull request as ready for review January 16, 2026 14:47
@jjuyeonkim jjuyeonkim added this pull request to the merge queue Jan 16, 2026
Merged via the queue into NOAA-GFDL:develop with commit 22c14ab Jan 16, 2026
5 checks passed
@romanc romanc deleted the romanc/replace-null-comm branch January 16, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants