Skip to content

BREAKING CHANGE: remove deprecated NullComm#350

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/deprecation-remove-null-comm
Jan 19, 2026
Merged

BREAKING CHANGE: remove deprecated NullComm#350
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/deprecation-remove-null-comm

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Jan 6, 2026 •
edited
Loading

Description

NullComm was deprecated with NDSL release 2025.11.00 in favor of MPIComm and LocalComm, see #318.

Blocked by NOAA-GFDL/pace#168, NOAA-GFDL/pace#173, NOAA-GFDL/pyFV3#116, NOAA-GFDL/pace#174

Related issue: #298

How has this been tested?

All good as long as CI is still green.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Jan 6, 2026 •
edited
Loading

Looks like NullComm is heavily used in pace. Easiest way might be to copy the class over to pace/comm.py, see NOAA-GFDL/pace#168.

@romanc romanc changed the title BREAKING CHANE: remove deprecated NullComm BREAKING CHANGE: remove deprecated NullComm Jan 8, 2026
This was referenced Jan 13, 2026
Merged
Merged
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Jan 16, 2026

NullComm is also used in pyFV3. PR NOAA-GFDL/pyFV3#116 is up to address this and move all instances to LocalComm.

@romanc romanc marked this pull request as ready for review January 16, 2026 20:03
@romanc romanc enabled auto-merge January 16, 2026 20:03
@romanc romanc disabled auto-merge January 16, 2026 20:07
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Jan 16, 2026

ah, we still need to propagate PR NOAA-GFDL/pyFV3#116 to pace ...

@romanc romanc mentioned this pull request Jan 16, 2026
Merged
7 tasks
@romanc romanc enabled auto-merge January 16, 2026 20:49
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented Jan 16, 2026

aaaand we should be good now 🎉

FlorianDeconinck
FlorianDeconinck approved these changes Jan 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long NullComm you did good 🧹

@romanc romanc added this pull request to the merge queue Jan 19, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 19, 2026
@romanc
BREAKING CHANE: remove deprecated NullComm (#350)
9ed5166 
Co-authored-by: Roman Cattaneo <1116746+romanc@users.noreply.github.com>
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 19, 2026
@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Jan 19, 2026
Merged via the queue into NOAA-GFDL:develop with commit c5705e0 Jan 19, 2026
6 of 10 checks passed
@romanc romanc deleted the romanc/deprecation-remove-null-comm branch January 19, 2026 16:48
@FlorianDeconinck FlorianDeconinck mentioned this pull request Feb 23, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romanc @FlorianDeconinck