FMS2: Move FMS domain calls to MOM infra#197
Conversation
The `set_domain` and `nullify_domain` calls used in FMS1 IO now pass through the MOM domain infra. Explicit references to the internal `mpp_domain` have also been removed.
|
This should not be merged until the corresponding MOM PR has been handled: |
|
@marshallward could you add one more mod to this PR? The following line is causing a compile issue, but the restart interfaces are not "used" anywhere in the file and the line can be deleted: https://github.com/NOAA-GFDL/SIS2/blob/dev/gfdl/src/ice_ridge.F90#L27 BTW, since the required MOM6 PR is handled this one can go in now, right? Thanks. |
|
Oops, I meant for that line to also be removed, thanks Niki. |
ice_ridge contained unused references to fms_io_mod, which is to be removed from FMS. This patch removes those lines.
|
Thanks @nikizadehgfdl the line has now been removed. I believe this is ready to be merged once it's been reviewed and tested. |
|
I have run CM4 and OM4 tests with this PR, both with infra/FMS1 and infra/FMS2, and with old and new fms tags and they all worked fine. |
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes would prevent the use of SIS2 with any versions of MOM6 that predate the incorporation of PR #394 into MOM6. This is a horrible practice, dictated by changes to the FMS interfaces in callous disregard for the continuity of projects using FMS.
Unfortunately, I do not see any alternative that would allow us to use the latest version of FMS2 but to accept these disruptive changes. However, I would note that MOM6 PR#394 is relatively simple, so it should be possible to cherry-pick it onto any older versions of MOM6 (or the version currently on the main branch) that we would need to use with the latest version of SIS2.
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This PR has passed the SIS2 pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/20010.
Although there are potentially disruptive version dependencies on MOM6 code versions, this commit will work with the version that is on the MOM6 dev/gfdl branch as of June 30, 2023, and will hopefully be merged onto the main branch of MOM6 soon.
The
set_domainandnullify_domaincalls used in FMS1 IO now pass through the MOM domain infra. Explicit references to the internalmpp_domainhave also been removed.