FMS2: New interface to set/nullify_domain#394
Merged
Hallberg-NOAA merged 1 commit intoJun 30, 2023
Conversation
This patch adds wrappers to the set_domain and nullify_domain functions used in FMS1 for internal FMS IO operations. These are not used in FMS2, so the wrapper functions are empty. This is required to eliminate FMS1 IO dependencies in SIS2.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #394 +/- ##
============================================
- Coverage 38.21% 38.21% -0.01%
============================================
Files 269 269
Lines 76407 76413 +6
Branches 14033 14033
============================================
Hits 29201 29201
- Misses 41963 41969 +6
Partials 5243 5243
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
approved these changes
Jun 30, 2023
Member
There was a problem hiding this comment.
These are useful changes for helping insulate MOM6 and SIS2 from changes to the FMS interfaces. They are have passed the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19683.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds wrappers to the set_domain and nullify_domain functions used in FMS1 for internal FMS IO operations. These are not used in FMS2, so the wrapper functions are empty.
This is required to eliminate FMS1 IO dependencies in SIS2.