Skip to content

Hotfix for grid generation use of mpi operators #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 1 commit into from
Jan 16, 2025
Merged

Hotfix for grid generation use of mpi operators #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ndsl/grid/generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import numpy as np

from ndsl.comm.comm_abc import ReductionOperator
from ndsl.comm.communicator import Communicator
from ndsl.constants import (
N_HALO_DEFAULT,
Expand Down Expand Up @@ -3428,7 +3429,11 @@ def _reduce_global_area_minmaxes(self):
max_area = self._np.max(self.area.data[3:-4, 3:-4])[()]
min_area_c = self._np.min(self.area_c.data[3:-4, 3:-4])[()]
max_area_c = self._np.max(self.area_c.data[3:-4, 3:-4])[()]
self._da_min = float(self._comm.comm.allreduce(min_area, min))
self._da_max = float(self._comm.comm.allreduce(max_area, max))
self._da_min_c = float(self._comm.comm.allreduce(min_area_c, min))
self._da_max_c = float(self._comm.comm.allreduce(max_area_c, max))
self._da_min = float(self._comm.comm.allreduce(min_area, ReductionOperator.MIN))
self._da_max = float(self._comm.comm.allreduce(max_area, ReductionOperator.MAX))
self._da_min_c = float(
self._comm.comm.allreduce(min_area_c, ReductionOperator.MIN)
)
self._da_max_c = float(
self._comm.comm.allreduce(max_area_c, ReductionOperator.MAX)
)