2D Stencil Indexing Method#54
Merged
Merged
Conversation
bensonr
reviewed
Aug 8, 2025
bensonr
approved these changes
Aug 11, 2025
fmalatino
approved these changes
Aug 11, 2025
romanc
pushed a commit
to romanc/NDSL
that referenced
this pull request
Aug 25, 2025
This PR is a follow-up from PR NOAA-GFDL#54. It moves and simplifies the test for GridIndexing.get_2d_compute_origin_domain(). This test does not need a stencil fectory and also doesn't depend on a {Stencil,Dace}Config.
7 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
This PR is a follow-up from PR #54. It moves and simplifies the test for GridIndexing.get_2d_compute_origin_domain(). This test does not need a stencil fectory and also doesn't depend on a {Stencil,Dace}Config. Co-authored-by: Roman Cattaneo <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
get_2d_compute_origin_domainmethod to GridIndexing in order to easily generate extents for 2D stencils.How Has This Been Tested?
test_stencil_factory_numpy_comparison_from_origin_domain_2d test added to the stencil factory tests
Checklist: