tests: Move test for GridIndexing.get_2d_compute_origin_domain()#209
Merged
Conversation
This PR is a follow-up from PR NOAA-GFDL#54. It moves and simplifies the test for GridIndexing.get_2d_compute_origin_domain(). This test does not need a stencil fectory and also doesn't depend on a {Stencil,Dace}Config.
Collaborator
Author
|
@oelbert friendly ping on the review here... |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
@oelbert / @fmalatino something seems to be off with the miniconda environment on the pyshield CI. Can you have a look? |
Contributor
@romanc we are actively trying to fix it. There are some issues getting an environment that will allow for an installation of pyrte-rrtmgp alongside pyshield. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up from PR #54. It moves and simplifies the test for
GridIndexing.get_2d_compute_origin_domain()because this test does not need a stencil factory and also doesn't depend on a{Stencil,Dace}Config. Or was the plan to actually do something with the stencils generated from the stencil factory?How Has This Been Tested?
Existing/moved test.
Checklist: