Skip to content

[Translate] Fix default shape for KJI / Fortran-aligned backend #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 8 commits into from
Apr 2, 2026
Merged

[Translate] Fix default shape for KJI / Fortran-aligned backend #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cad7128
Fix default shape for KJI / Fortran-aligned backend
FlorianDeconinck Mar 27, 2026
88b65f2
Test to trip lint on CI but not locally (again)
FlorianDeconinck Mar 27, 2026
1628f73
Default to `Any` because we can't list all `dtypes` and we can't filt…
FlorianDeconinck Mar 27, 2026
09fc301
Missing files
FlorianDeconinck Mar 27, 2026
7c7b2dd
Restore `self.maxshape` since it's used outside (sic) the inner trans…
FlorianDeconinck Mar 27, 2026
0af74ad
Merge remote-tracking branch 'NOAA/develop' into fix/translate_for_fo…
FlorianDeconinck Apr 2, 2026
4218128
Fix type hint in `xumpy`
FlorianDeconinck Apr 2, 2026
d1c2172
Use np.floating generic type hint
FlorianDeconinck Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ndsl/stencils/testing/translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def pad_field_in_j(field, nj: int, backend: Backend):
def as_numpy(
value: dict[str, Any] | Quantity | np.ndarray,
) -> np.ndarray | dict[str, np.ndarray]:
def _convert(value: Quantity | np.ndarray) -> np.ndarray:
def _convert(value: Any) -> np.ndarray:
if isinstance(value, Quantity):
return value.data
elif isinstance(value, np.ndarray):
Expand Down Expand Up @@ -74,10 +74,13 @@ def __init__(
self.out_vars: dict[str, Any] = {}
self.write_vars: list = []
self.grid = grid
self.maxshape: tuple[int, ...] = grid.domain_shape_full(add=(1, 1, 1))
self.ordered_input_vars = None
self.ignore_near_zero_errors: dict[str, Any] = {}
self.skip_test = skip_test
if self.stencil_factory.backend.is_fortran_aligned():
self.maxshape = self.grid.domain_shape_full()
else:
self.maxshape = self.grid.domain_shape_full(add=(1, 1, 1))

def extra_data_load(self, data_loader: DataLoader):
pass
Expand Down
11 changes: 2 additions & 9 deletions ndsl/xumpy/alloc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import numpy as np
import numpy.typing as npt
from numpy._typing import _SupportsDType

from ndsl.config import Backend
from ndsl.dsl.typing import Float
Expand All @@ -14,12 +13,6 @@

# Taking a page from cupy's playbook to have tuple & ndarray
_ShapeLike = SupportsIndex | Sequence[SupportsIndex]
_DTypeLikeFloat32 = (
np.dtype[np.float32] | _SupportsDType[np.dtype[np.float32]] | type[np.float32]
)
_DTypeLikeFloat64 = (
np.dtype[np.float64] | _SupportsDType[np.dtype[np.float64]] | type[np.float64]
)


def zeros(
Expand Down Expand Up @@ -55,7 +48,7 @@ def empty(
def full(
shape: _ShapeLike,
backend: Backend,
value: np.ScalarType,
value: npt.DTypeLike,
dtype: npt.DTypeLike = Float,
) -> np.ndarray | cp.ndarray:
if backend.is_gpu_backend():
Expand All @@ -66,7 +59,7 @@ def full(
def random(
shape: _ShapeLike,
backend: Backend,
dtype: _DTypeLikeFloat32 | _DTypeLikeFloat64 = Float, # type: ignore [valid-type]
dtype: np.floating = Float,
) -> np.ndarray | cp.ndarray:
if backend.is_gpu_backend():
gen = cp.random.default_rng()
Expand Down