[Translate] Fix default shape for KJI / Fortran-aligned backend#409
Merged
FlorianDeconinck merged 8 commits intoApr 2, 2026
Conversation
CharlesKrop
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new fortran-aligned backend remove the extra point on the memory. This has a knock-on effect for translate test where the
make_from_storageuses amake_storage_datathat will default if no shape is given as an input.That default do not look at the backend, it takes the full grid and add 1.
This PR fixes this and shows that we need a proper way to tie allocation reality and grid read for the translate test. This would be a central question if we forced the Translate test to use Quantities.
How has this been tested?
Local test with `st:dace:cpu:KJI" backend
Checklist