Skip to content

[Translate] Fix default shape for KJI / Fortran-aligned backend#409

Merged
FlorianDeconinck merged 8 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:fix/translate_for_fortran_memory_aligned
Apr 2, 2026
Merged

[Translate] Fix default shape for KJI / Fortran-aligned backend#409
FlorianDeconinck merged 8 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:fix/translate_for_fortran_memory_aligned

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Description

The new fortran-aligned backend remove the extra point on the memory. This has a knock-on effect for translate test where the make_from_storage uses a make_storage_data that will default if no shape is given as an input.

That default do not look at the backend, it takes the full grid and add 1.

This PR fixes this and shows that we need a proper way to tie allocation reality and grid read for the translate test. This would be a central question if we forced the Translate test to use Quantities.

How has this been tested?

Local test with `st:dace:cpu:KJI" backend

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Apr 2, 2026
Merged via the queue into NOAA-GFDL:develop with commit bfeac8e Apr 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants