Skip to content

Type tweak: Allow ZarrMonitor to take in Comm | DummyComm | None #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjuyeonkim wants to merge 2 commits into from
Closed

Type tweak: Allow ZarrMonitor to take in Comm | DummyComm | None #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a89f0
Type tweak: Allow ZarrMonitor to take in Comm | DummyComm | None
jjuyeonkim Oct 28, 2025
163703b
Merge branch 'develop' into 20251028_type_tweak
jjuyeonkim Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ndsl/monitor/zarr_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import xarray as xr

import ndsl.constants as constants
from ndsl.comm import Comm
from ndsl.comm.partitioner import Partitioner, subtile_slice
from ndsl.logging import ndsl_log
from ndsl.monitor.convert import to_numpy
Expand Down Expand Up @@ -47,7 +48,7 @@ def __init__(
store: str | zarr.storage.MutableMapping,
partitioner: Partitioner,
mode: str = "w",
mpi_comm: DummyComm | None = None,
mpi_comm: Comm | DummyComm | None = None,
Copy link
Copy Markdown
Collaborator Author

@jjuyeonkim jjuyeonkim Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an alternative could be to try having mpi_comm: Comm | None = None. Then, maybe have DummyComm inherit from Comm.

) -> None:
"""Create a ZarrMonitor.

Expand Down