Type tweak: Allow ZarrMonitor to take in Comm | DummyComm | None#290
Closed
jjuyeonkim wants to merge 2 commits into
Closed
Type tweak: Allow ZarrMonitor to take in Comm | DummyComm | None#290jjuyeonkim wants to merge 2 commits into
jjuyeonkim wants to merge 2 commits into
Conversation
7 tasks
fmalatino
approved these changes
Oct 28, 2025
jjuyeonkim
commented
Oct 28, 2025
| partitioner: Partitioner, | ||
| mode: str = "w", | ||
| mpi_comm: DummyComm | None = None, | ||
| mpi_comm: Comm | DummyComm | None = None, |
Collaborator
Author
There was a problem hiding this comment.
I think an alternative could be to try having mpi_comm: Comm | None = None. Then, maybe have DummyComm inherit from Comm.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small proposed type adjustment for the Zarr Monitor. Without this, there are type linting errors when attempting to update the submodules for Pace: NOAA-GFDL/pace#156
How has this been tested?
CI passes, linting passes in Pace locally with this update
Checklist