Skip to content

[Translate] Allow slicing of N-Dimensions fields#273

Merged
FlorianDeconinck merged 7 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:feature/translate_nDim_inputs
Oct 23, 2025
Merged

[Translate] Allow slicing of N-Dimensions fields#273
FlorianDeconinck merged 7 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:feature/translate_nDim_inputs

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck commented Oct 22, 2025

Description

We introduce a proper split between cartesian and data dimensions for slicing of N dimensions field in the input marshaling of translate data.

This completes the support for N dimensional inputs/outputs in the translate test.

  • Better type hints

How has this been tested?

This doesn't touch the original behavior of "tracers as dictionary" which was the way to do 4D fields. This new feature is tested locally on the GEOS v11 version of dynamics.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I understand how exactly this is working without running through an example. Code-wise it looks good to me. The npt import is an esthetic question.

Comment thread ndsl/dsl/gt4py_utils.py
@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NOAA-GFDL:develop with commit e65319d Oct 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants