[Translate] Allow slicing of N-Dimensions fields#273
Merged
FlorianDeconinck merged 7 commits intoOct 23, 2025
Merged
Conversation
romanc
approved these changes
Oct 23, 2025
Collaborator
romanc
left a comment
There was a problem hiding this comment.
Can't say I understand how exactly this is working without running through an example. Code-wise it looks good to me. The npt import is an esthetic question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We introduce a proper split between cartesian and data dimensions for slicing of N dimensions field in the input marshaling of translate data.
This completes the support for N dimensional inputs/outputs in the translate test.
How has this been tested?
This doesn't touch the original behavior of "tracers as dictionary" which was the way to do 4D fields. This new feature is tested locally on the GEOS v11 version of dynamics.
Checklist