(WIP) [Translate] Allow for generic slicing of Nth dims#212
Closed
FlorianDeconinck wants to merge 2 commits into
Closed
(WIP) [Translate] Allow for generic slicing of Nth dims#212FlorianDeconinck wants to merge 2 commits into
FlorianDeconinck wants to merge 2 commits into
Conversation
Undo the bespoke `names_4D` from AI2 days
Collaborator
Author
|
@romanc This isn't going to pass tests because it's one of the few breaking changes that I need to either square or hard flip with the new dynamics. But you'll need it to run the translate or Remapping & Tracer2D1L |
Collaborator
|
Is it okay to leave this here for a week or so until we untangle the M2 branch? If we need it as a breaking change for Geos v11.4, we might want to have a separate branch to accumulate related changes into and then merge with the Geos v11. 4 update. |
FlorianDeconinck
changed the title
Collaborator
Author
|
I think I can fabricate a backward comptabile system or at least fix the model side of things. Let's leave it here for now - you know you can pull the changes locally if you need them |
FlorianDeconinck
added
the
Scheduled for next Release
Collaborator
Author
|
Super-seeded by #273 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And undo the bespoke
names_4Dfrom AI2 days