Skip to content

Bug fix in MOM_open_boundary #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hallberg-NOAA merged 1 commit into from
Sep 19, 2025
Merged

Bug fix in MOM_open_boundary #964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/core/MOM_open_boundary.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,17 +1330,20 @@ subroutine initialize_obc_tides(OBC, US, param_file)
"Fixed reference date to use for nodal modulation of boundary tides.", &
old_name="OBC_TIDE_NODAL_REF_DATE", defaults=(/0, 0, 0/), do_not_log=tides)

if (.not. OBC%add_eq_phase) then
! If equilibrium phase argument is not added, the input phases
! should already be relative to the reference time.
call MOM_mesg('OBC tidal phases will *not* be corrected with equilibrium arguments.')
endif

allocate(OBC%tide_names(OBC%n_tide_constituents))
read(tide_constituent_str, *) OBC%tide_names

! Set reference time (t = 0) for boundary tidal forcing.
OBC%time_ref = set_date(tide_ref_date(1), tide_ref_date(2), tide_ref_date(3), 0, 0, 0)
if (sum(tide_ref_date) == 0) then ! tide_ref_date defaults to 0.
OBC%time_ref = set_date(1, 1, 1, 0, 0, 0)
else
if (.not. OBC%add_eq_phase) then
! If equilibrium phase argument is not added, the input phases
! should already be relative to the reference time.
call MOM_mesg('OBC tidal phases will *not* be corrected with equilibrium arguments.')
endif
OBC%time_ref = set_date(tide_ref_date(1), tide_ref_date(2), tide_ref_date(3), 0, 0, 0)
endif

! Find relevant lunar and solar longitudes at the reference time
if (OBC%add_eq_phase) call astro_longitudes_init(OBC%time_ref, OBC%tidal_longitudes)
Expand Down