Skip to content

Bug fix in MOM_open_boundary#964

Merged
Hallberg-NOAA merged 1 commit into
NOAA-GFDL:dev/gfdlfrom
c2xu:c2xu/open_boundary
Sep 19, 2025
Merged

Bug fix in MOM_open_boundary#964
Hallberg-NOAA merged 1 commit into
NOAA-GFDL:dev/gfdlfrom
c2xu:c2xu/open_boundary

Conversation

@c2xu
Copy link
Copy Markdown

@c2xu c2xu commented Aug 27, 2025

Fixed the inconsistency for defining the reference time of tides in MOM_tidal_forcing and MOM_open_boundary.

@Hallberg-NOAA
Copy link
Copy Markdown
Member

This change looks correct to me, and it should correctly handle the case where the tidal reference date has not been set. However, I think that we should wait to formally approve this PR until after it has undergone the testing with CEFI regional configurations.

@Hallberg-NOAA Hallberg-NOAA added bug Something isn't working answer-changing A change in results (actual or potential) labels Sep 6, 2025
Copy link
Copy Markdown
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look correct and reasonable to me, and based on my inspection of the FMS time_manager code, I am confident that all cases that used the default reference date and did not include this fix would have failed. Although this does constitute a defacto change in the default behavior, I think that this is a reasonable change and one that will not break any existing configurations.

Fixed the inconsistency for defining the reference time of tides in
MOM_tidal_forcing and MOM_open_boundary.
@Hallberg-NOAA
Copy link
Copy Markdown
Member

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/28888.

@Hallberg-NOAA Hallberg-NOAA merged commit dcae198 into NOAA-GFDL:dev/gfdl Sep 19, 2025
52 checks passed
@c2xu c2xu deleted the c2xu/open_boundary branch November 17, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

answer-changing A change in results (actual or potential) bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants