+Correct units in 1 get_param call and 64 comments#327
Merged
marshallward merged 4 commits intoMar 1, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #327 +/- ##
=========================================
Coverage 37.16% 37.16%
=========================================
Files 265 265
Lines 74508 74508
Branches 13839 13839
=========================================
+ Hits 27689 27692 +3
+ Misses 41725 41723 -2
+ Partials 5094 5093 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
force-pushed
the
fix_bad_units_in_comments
branch
from
894257d to
2ddfbe0
Compare
Corrected the units in the get_param call for WAVE_HEIGHT_SCALE_FACTOR, and corrected the units descriptions in comments of 22 wind stress related variables in 6 driver routines, from [R L Z T-1 ~> Pa] to [R L Z T-2 ~> Pa], but the actual conversion factors in the code are correct. Also fixed 42 other inconsistent units in comments in 28 files scattered throughout the MOM6 code. WAVE_HEIGHT_SCALE_FACTOR was added in December 2022 as a part of PR mom-ocean#289 to dev/gfdl. These inconsistent units were detected because they do not match the patterns of other valid units; most are recent additions. Apart from a single unit in a get_param call, only comments are changed, and all answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
fix_bad_units_in_comments
branch
from
2ddfbe0 to
93f6734
Compare
Hallberg-NOAA
changed the title
marshallward
approved these changes
Feb 24, 2023
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/18411 ✔️ 🟡 |
This was referenced Apr 6, 2023
marshallward
pushed a commit
that referenced
this pull request
Apr 15, 2025
This PR introduces the calculate_mld_003 subroutine, previously a code black in mixedlayer_restrat_OM4, so as to make it available in mixedlayer_restrat_bodner as well. The newly added flag BODNER_USE_MLD_003 determines whether mld_003 is indeed used in mixedlayer_restrat_bodner. * make MLD_003 computation available to mixedlayer_restrat_Bodner * add missing params to Bodner MLD detection and rename new subroutine and runtime parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the units in the get_param call for WAVE_HEIGHT_SCALE_FACTOR, and corrected the units descriptions in comments of 22 wind stress related variables in 6 driver routines, from [R L Z T-1 ~> Pa] to [R L Z T-2 ~> Pa], but the actual conversion factors in the code are correct. Also fixed 42 other inconsistent units in comments in 28 files scattered throughout the MOM6 code. WAVE_HEIGHT_SCALE_FACTOR was added in December 2022 as a part of PR #289 to dev/gfdl. These inconsistent units were detected because they do not match the patterns of other valid units; most are recent additions. Apart from a single unit in a get_param call, only comments are changed, and all answers are bitwise identical.