+Add runtime parameters for MOM_wave_interface#289
Merged
marshallward merged 2 commits intoDec 29, 2022
Conversation
Added 7 new runtime parameters (LA_DEPTH_MIN, DHH85_MIN_WAVE_FREQ, DHH85_MAX_WAVE_FREQ, RHO_AIR, VISCOSITY_AIR, WAVE_HEIGHT_SCALE_FACTOR and VON_KARMAN_WAVES) to specify the previously hard-coded dimensional parameters in the MOM_wave_interface module. Because there are several different ways to set the parameters related to the Langmuir number calculation, several of these parameters are set in the new private subroutine set_LF17_wave_params, which in turn is called in two different places. Some comments were also added to annotate the units of some of the variables in this module. By default all answers are bitwise identical, but there are new entries in the MOM_parameter_doc.all files for some configurations that use the MOM6 surface wave module.
Hallberg-NOAA
added
documentation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #289 +/- ##
============================================
- Coverage 37.08% 37.07% -0.01%
============================================
Files 263 263
Lines 73611 73620 +9
Branches 13719 13720 +1
============================================
Hits 27296 27296
- Misses 41278 41287 +9
Partials 5037 5037
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
breichl
approved these changes
Dec 23, 2022
breichl
left a comment
breichl
left a comment
There was a problem hiding this comment.
The ability to set these parameters at runtime is an improvement to the code and looks correct to me. The additional comments also look to improve the description of the code.
marshallward
approved these changes
Dec 29, 2022
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
Approved on behalf of @breichl
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17819 ✔️ 🟡 |
marshallward
pushed a commit
that referenced
this pull request
Mar 1, 2023
Corrected the units in the get_param call for WAVE_HEIGHT_SCALE_FACTOR, and corrected the units descriptions in comments of 22 wind stress related variables in 6 driver routines, from [R L Z T-1 ~> Pa] to [R L Z T-2 ~> Pa], but the actual conversion factors in the code are correct. Also fixed 42 other inconsistent units in comments in 28 files scattered throughout the MOM6 code. WAVE_HEIGHT_SCALE_FACTOR was added in December 2022 as a part of PR #289 to dev/gfdl. These inconsistent units were detected because they do not match the patterns of other valid units; most are recent additions. Apart from a single unit in a get_param call, only comments are changed, and all answers are bitwise identical.
This was referenced Apr 6, 2023
marshallward
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Adding Ohlmann solar pentration scheme to MOM_optics * Fixed some violations of code style guide * Fixing a few more code style violations * Fixing yet another code style guide violation * Cleaned up some coment statements. No changes to code. * Fixed formatting of string in get_param. Cleaned up extraneous FOB footprints in comments * Fix spelling (Ohlman to Ohlmann) --------- Co-authored-by: Gustavo Marques <gmarques@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 7 new runtime parameters (LA_DEPTH_MIN, DHH85_MIN_WAVE_FREQ, DHH85_MAX_WAVE_FREQ, RHO_AIR, VISCOSITY_AIR, WAVE_HEIGHT_SCALE_FACTOR and VON_KARMAN_WAVES) to specify the previously hard-coded dimensional parameters in the MOM_wave_interface module. Because there are several different ways to set the parameters related to the Langmuir number calculation, several of these parameters are set in the new private subroutine set_LF17_wave_params, which in turn is called in two different places. Some comments were also added to annotate the units of some of the variables in this module. By default all answers are bitwise identical, but there are new entries in the MOM_parameter_doc.all files for some configurations that use the MOM6 surface wave module.