Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#388
Merged
vithikashah001 merged 9 commits intoNov 25, 2025
Merged
Conversation
This was referenced Aug 7, 2025
Merged
Contributor
|
@DusanJovic-NOAA @jkbk2004 - if #386 is acceptable, we should consider bundling it in with this one. |
bensonr
approved these changes
Aug 8, 2025
vithikashah001
approved these changes
Aug 19, 2025
rem1776
approved these changes
Aug 19, 2025
XiaqiongZhou-NOAA
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
This PR removes local copy of FindESMF.cmake and renames esmf target to ESMF::ESMF. ufs-weather-model now uses the FindESMF.cmake module provided by the ESMF library.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
ufs-weather-model regression test has been run on Ursa and WCOSS2. No change in baselines is expected.
Checklist:
Please check all whether they apply or not