Skip to content

Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#388

Merged
vithikashah001 merged 9 commits into
NOAA-GFDL:dev/emcfrom
DusanJovic-NOAA:remove_findesmf
Nov 25, 2025
Merged

Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#388
vithikashah001 merged 9 commits into
NOAA-GFDL:dev/emcfrom
DusanJovic-NOAA:remove_findesmf

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Contributor

@DusanJovic-NOAA DusanJovic-NOAA commented Aug 7, 2025

Description

Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.

This PR removes local copy of FindESMF.cmake and renames esmf target to ESMF::ESMF. ufs-weather-model now uses the FindESMF.cmake module provided by the ESMF library.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

ufs-weather-model regression test has been run on Ursa and WCOSS2. No change in baselines is expected.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bensonr
Copy link
Copy Markdown
Contributor

bensonr commented Aug 8, 2025

@DusanJovic-NOAA @jkbk2004 - if #386 is acceptable, we should consider bundling it in with this one.

@vithikashah001 vithikashah001 merged commit 0ca27ba into NOAA-GFDL:dev/emc Nov 25, 2025
@DusanJovic-NOAA DusanJovic-NOAA deleted the remove_findesmf branch December 1, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants