Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#1000
Merged
FernandoAndrade-NOAA merged 28 commits intoDec 1, 2025
Merged
Conversation
Collaborator
|
Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process WM PR #2406 sometime next week? |
BrianCurtis-NOAA
approved these changes
Sep 25, 2025
Collaborator
|
@DusanJovic-NOAA atmos_cubed_sphere PR 388 has merged. Please go ahead and revert .gitmodules/update hash to 0ca27ba. |
Collaborator
|
Testing for WM parent PR #2406 has passed, the atmos_cubed_sphere PR 388 has been merged, and Dusan has reverted .gitmodules/updated the hash. This PR is ready to merge. |
FernandoAndrade-NOAA
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes local copy of FindESMF.cmake and renames esmf target to ESMF::ESMF. ufs-weather-model now uses the FindESMF.cmake module provided by the ESMF library. No change in the baselines is expected.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? ufs-weather-model regression test
What compilers / HPCs was it tested with? Intel/GNU on Ursa
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes. On what platform? Ursa.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs