Skip to content

Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#1000

Merged
FernandoAndrade-NOAA merged 28 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:remove_findesmf
Dec 1, 2025
Merged

Remove local copy of FindESMF.cmake and rename esmf target to ESMF::ESMF#1000
FernandoAndrade-NOAA merged 28 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:remove_findesmf

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Description

This PR removes local copy of FindESMF.cmake and renames esmf target to ESMF::ESMF. ufs-weather-model now uses the FindESMF.cmake module provided by the ESMF library. No change in the baselines is expected.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? ufs-weather-model regression test
What compilers / HPCs was it tested with? Intel/GNU on Ursa
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes. On what platform? Ursa.

  • Will the code updates change regression test baseline? No.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process WM PR #2406 sometime next week?

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA atmos_cubed_sphere PR 388 has merged. Please go ahead and revert .gitmodules/update hash to 0ca27ba.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Testing for WM parent PR #2406 has passed, the atmos_cubed_sphere PR 388 has been merged, and Dusan has reverted .gitmodules/updated the hash. This PR is ready to merge.

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit deda0c0 into NOAA-EMC:develop Dec 1, 2025
8 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the remove_findesmf branch December 1, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants