Fix: Veritical Remapping on restarts#374
Merged
Merged
Conversation
* correcting restart reads in remap_restarts to be read in by read_restart and not read_data * cleanup a few comments in fv_io. Remove is_optional from the registering of some remap restart fields in fv_io.
Add CONTRIBUTING_GUIDE.md to main branch
…NABLE_QUAD_PRECISION (NOAA-GFDL#298)
lharris4
suggested changes
Feb 21, 2025
Contributor
lharris4
left a comment
lharris4
left a comment
There was a problem hiding this comment.
One minor typo; otherwise very glad to see this contribution from our community partners.
lharris4
approved these changes
Feb 21, 2025
bensonr
approved these changes
Feb 21, 2025
This was referenced Mar 3, 2025
|
tests are done at ufs-community/ufs-weather-model#2487. @bensonr @lharris4 @XiaqiongZhou-NOAA @laurenchilutti Can you go ahead to merge this pr? |
14 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was reported that "When we restart a simulation with a different vertical grid, the phis field becomes distorted, copying the same section of the field over the whole tile according to the number of processors per tile". We fixed this by using the correct fms2io function for reading restarts.
I am also including two other minor changes:
Fixes #204
How Has This Been Tested?
We have tested this with the SHiELD model at GFDL.
Also tested by @rurata
Checklist:
Please check all whether they apply or not