Skip to content

Minor modification and bug fix in GFS cumulus convection schemes#885

Merged
jkbk2004 merged 46 commits into
NOAA-EMC:developfrom
rhaesung:conv_hr5update
Mar 6, 2025
Merged

Minor modification and bug fix in GFS cumulus convection schemes#885
jkbk2004 merged 46 commits into
NOAA-EMC:developfrom
rhaesung:conv_hr5update

Conversation

@rhaesung
Copy link
Copy Markdown
Contributor

@rhaesung rhaesung commented Oct 31, 2024

Description

This PR mainly involves changes in ccpp-physics, and the code was provided by @JongilHan66.

  1. Modified prognostic updraft fraction (sigmab) calculation in 'progsigma_calc.f90' which is physically more sound:
    a) moisture convergence calculation: integrate from the convection source level rather than from the cloud base
    b) 2D advection of sigmab: sigmab advection averaged over the cloud layers rather than taking a maximum sigmab advection from k=2 to the model top
    c) To suppress unrealistically large reflectivity in the model first time step, minimum sigmab at the first time step is set to zero

  2. Fix in missing vertical transport of turbulent kinetic energy (TKE) when aerosol transport is turned on (samfdeepcnv.f & samfshalcnv.f)

  3. Introduce TKE at model layer interfaces (tkeh) for use in convection schemes (CCPP_typedefs.F90, CCPP_typedefs.meta, satmedmfvdifq.F, satmedmfvdifq.meta, samfdeepcnv.f, samfdeepcnv.meta, samfshalcnv.f, and samfshalcnv.meta)

  4. Vertical transports of hydrometeor variables are currently not allowed in the convection schemes. But vertical transports of number concentrations of only cloud water and ice are mistakenly allowed, which is fixed in this update (CCPP_typedefs.F90)

  5. All the modifications and bug fixes above had neutral impacts on the GFS forecasts

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

Comment thread ccpp/data/GFS_typedefs.F90 Outdated
Comment thread ccpp/data/GFS_typedefs.meta Outdated
Comment thread ccpp/data/GFS_typedefs.F90 Outdated
@rhaesung rhaesung requested a review from JongilHan66 March 3, 2025 13:43
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Mar 3, 2025

@rhaesung can you point to https://github.com/laurenchilutti/GFDL_atmos_cubed_sphere/tree/remap_io_emc? NOAA-GFDL/GFDL_atmos_cubed_sphere#374 has no impact on weather model baselines. So it's good to bring it in.

@rhaesung
Copy link
Copy Markdown
Contributor Author

rhaesung commented Mar 3, 2025

@rhaesung can you point to https://github.com/laurenchilutti/GFDL_atmos_cubed_sphere/tree/remap_io_emc? NOAA-GFDL/GFDL_atmos_cubed_sphere#374 has no impact on weather model baselines. So it's good to bring it in.

@jkbk2004 Done!

@grantfirl
Copy link
Copy Markdown
Collaborator

@rhaesung ufs-community/ccpp-physics#232 is merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@435e80a) and revert .gitmodules in preparation for merge.

@rhaesung
Copy link
Copy Markdown
Contributor Author

rhaesung commented Mar 6, 2025

@rhaesung ufs-community/ccpp-physics#232 is merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@435e80a) and revert .gitmodules in preparation for merge.

@grantfirl Thanks, done!

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Mar 6, 2025

@rhaesung can you update cubed sphere hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@127a341 ?

@rhaesung
Copy link
Copy Markdown
Contributor Author

rhaesung commented Mar 6, 2025

@rhaesung can you update cubed sphere hash: NOAA-GFDL/GFDL_atmos_cubed_sphere@127a341 ?

@jkbk2004 Sure, done!

@jkbk2004 jkbk2004 merged commit 41df0d8 into NOAA-EMC:develop Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants