Skip to content

Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90#338

Merged
laurenchilutti merged 3 commits into
NOAA-GFDL:dev/emcfrom
climbfuji:feature/ccpp_data_thrd_cnt
May 21, 2024
Merged

Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90#338
laurenchilutti merged 3 commits into
NOAA-GFDL:dev/emcfrom
climbfuji:feature/ccpp_data_thrd_cnt

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Apr 27, 2024

Description

All in the title. Required for supporting optional arguments in CCPP (see ufs-community/ufs-weather-model#2205 and PRs listed there).

Working towards NCAR/ccpp-framework#540

This is part of a large set of PRs:

NCAR/ccpp-framework#552
NOAA-EMC/ufsatm#807
https://github.com/ufs-community/ufs-weather-model/pull/2205
ufs-community/ccpp-physics#189
NCAR/ccpp-framework#556 (can be scheduled and merged anytime beforehand)
#338
NOAA-PSL/stochastic_physics#79

How Has This Been Tested?

ufs-weather-model full regression testing on Hera (all tests b4b)

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@climbfuji climbfuji changed the title WIP - Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90 Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90 May 11, 2024
@climbfuji climbfuji marked this pull request as ready for review May 11, 2024 02:57
@climbfuji
Copy link
Copy Markdown
Author

@bensonr This complicated PR is finally open for review

@FernandoAndrade-NOAA
Copy link
Copy Markdown

Testing for #2205 has completed successfully, please continue with merging this PR.

@laurenchilutti laurenchilutti merged commit 061a736 into NOAA-GFDL:dev/emc May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants