Add support for optional arguments in ccpp physics and framework#807
Merged
jkbk2004 merged 35 commits intoMay 21, 2024
Conversation
…review and testing
…ashes min-1' and update long name to make clear this is per 5 minutes
…es per minute to flashes per 5 minutes to match diagnostic units
…ture/ccpp_framework_merge_feature_capgen_into_main_20240308
…review and testing
…ture/ccpp_prebuild_optarg
…ture/ccpp_prebuild_optarg
…internally bend everything back to where it's expected (affects some, but not all variables in CCPP_typedefs.{F90,meta})
…d, remove active attribute
… variables are active for options 2,3,22,33 of gwd, not just 3,33
…located, remove active attribute
…; optional arguments in stochastic_physics/stochastic_physics_wrapper.F90
…for code review and testing
…ture/ccpp_prebuild_optarg
This was referenced May 11, 2024
climbfuji
commented
May 11, 2024
climbfuji
commented
May 11, 2024
Collaborator
Author
|
@DusanJovic-NOAA This PR and associated PRs are finally ready for review. All regression tests are b4b identical with the current baseline (tested with code up to develop 2024/05/10). |
15 tasks
DusanJovic-NOAA
approved these changes
May 13, 2024
…ture/ccpp_prebuild_optarg
…re, ccpp/framework, ccpp/physics
jkbk2004
approved these changes
May 21, 2024
FernandoAndrade-NOAA
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
May 21, 2024
…add end of run restart functionality to MOM6 (was #2286) (#2205) * UFSWM - Add support for optional arguments in ccpp physics and framework * FV3 - [Add support for optional arguments in ccpp physics and framework](NOAA-EMC/ufsatm#807 (comment)) * ccpp-physics - Introduce optional arguments in ccpp schemes and metadata * ccpp-framework - Add support (and tests) for optional arguments in ccpp_prebuild * atmos_cubed_sphere - Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90 * MOM6 - Add end of run restart functionality to MOM6 * stochastic_physics - Add optional attribute for variables where necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes necessary changes for supporting optional arguments in CCPP (see ufs-community/ufs-weather-model#2205 and PRs listed there).
This is part of a large set of PRs:
NCAR/ccpp-framework#552
#807
https://github.com/ufs-community/ufs-weather-model/pull/2205
ufs-community/ccpp-physics#189
NCAR/ccpp-framework#556 (can be scheduled and merged anytime beforehand)
NOAA-GFDL/GFDL_atmos_cubed_sphere#338
NOAA-PSL/stochastic_physics#79
Issue(s) addressed
Working towards NCAR/ccpp-framework#540
Testing
ufs-weather-model full regression testing on Hera (all tests b4b)
Dependencies
Waiting on: