Skip to content

Cherrypick PR283 from dev/emc to main#296

Merged
laurenchilutti merged 3 commits into
NOAA-GFDL:mainfrom
laurenchilutti:PR283main
Oct 19, 2023
Merged

Cherrypick PR283 from dev/emc to main#296
laurenchilutti merged 3 commits into
NOAA-GFDL:mainfrom
laurenchilutti:PR283main

Conversation

@laurenchilutti
Copy link
Copy Markdown
Member

Description

When cherry-picking the changes from PR #283 I noticed that model/fv_regional_bc.F90 should also be modified to have an axis type matching the precision that the dycore is built with and not hard-coded double precision.

Fixes # (issue)

How Has This Been Tested?

Tested with SHiELD on Gaea

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thank you for taking care of this. I see that the calls to register_field in atmos_cubed_sphere all use "double". Should we change that too?

@laurenchilutti
Copy link
Copy Markdown
Member Author

Yes I think that we should also change the other register_field calls. I will make the changes and do some more testing.

@laurenchilutti laurenchilutti merged commit 5f5ee36 into NOAA-GFDL:main Oct 19, 2023
linjiongzhou pushed a commit to linjiongzhou/GFDL_atmos_cubed_sphere that referenced this pull request Feb 28, 2025
Cherrypick PR283 from dev/emc to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants