Write netcdf axis variables using the same real kind as data variables#283
Merged
Merged
Conversation
laurenchilutti
approved these changes
Sep 20, 2023
41 tasks
6 tasks
|
@laurenchilutti All tests are done at ufs-community/ufs-weather-model#1903. Please, go ahead to merge this pr. |
bensonr
approved these changes
Sep 26, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the axis data type in restart files is always "double" regardless of the data type (float vs. double) of used for data variables. This PR updates io routines so that axis data type corresponds to the actual precision used for data variables.
This change is necessary to make restart files bit-identical to the restart files written out by the write grid component in UFS weather model.
Fixes # (issue)
NOAA-EMC/ufsatm#696
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Full regression test of the ufs weather model passed on Hera (both Intel and GNU compilers) and Orion.
Checklist:
Please check all whether they apply or not