dev/emc: Release FV3 Solver Updates (cherry-pick)#266
Merged
Conversation
* Bringing over internal updates to nh_core and nh_utils which includes a revision to the semi-implicit solver to linearize vertical sound wave propagation about the hydrostatic state. * resolve inconsistent use of single and double precision in rayleigh damping. Address spacing change. * rename tau_w * Modify the rff calculation to be fully double precision. Fixed a mistake in the previous cherry-pick commit * fully implement the name change of tau_w to fast_tau_w_sec
6 tasks
Member
Author
|
Hi @XiaqiongZhou-NOAA I have reintroduced these changes with one cherry-pick of the merge commit of PR 261. Could you give this one final review (the changes should be identical to PR 262). Should I create PRs to fv3atm and ufs-weather-model? |
XiaqiongZhou-NOAA
approved these changes
Apr 21, 2023
Contributor
XiaqiongZhou-NOAA
left a comment
XiaqiongZhou-NOAA
left a comment
There was a problem hiding this comment.
looks good to me
Contributor
|
Lauren: |
This was referenced Apr 24, 2023
bensonr
approved these changes
Apr 26, 2023
|
@bensonr @laurenchilutti All tests are done at ufs-community/ufs-weather-model#1720. Can you merge in this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks changes form PR #261 to dev/emc
This includes updates on behalf of Lucas Harris including:
Revision to semi-implicit solver to linearize vertical sound wave propagation about the hydrostatic state. This has been extensively tested by GFDL and EMC in SHiELD, GFS, and RRFS.
This replaces PR #262 with the most efficient cherry-pick of changes from PR 261. This should not be squash merged so we can maintain the commit history.
Fixes # (issue)
How Has This Been Tested?
Tested on the main branch with SHiELD
Checklist:
Please check all whether they apply or not