dev/emc: Release FV3 solver updates#262
Conversation
… a revision to the semi-implicit solver to linearize vertical sound wave propagation about the hydrostatic state.
|
"tau_w" is already used in explicit Rayleigh damping in dev/emc branch. Can the new-added "tau_w" change to another name? Otherwise, there are conflicts when compiling. |
|
Hi, Kate. I believe that this revision to the Rayleigh damping on w is
considerably more sophisticated and effective than that used in the
explicit Rayleigh damping; Kevin V was working on something similar.
If tau_w is disabled in dev/emc is w still damped? This is the behavior in
main and dev/gfdl. Also is anyone using tau_w in dev/emc?
Thanks,
Lucas
…On Wed, Apr 19, 2023 at 10:41 AM XiaqiongZhou-NOAA ***@***.***> wrote:
"tau_w" is already used in explicit Rayleigh damping in dev/emc branch.
Can the new-added "tau_w" change to another name? Otherwise, there are
conflicts when compiling.
—
Reply to this email directly, view it on GitHub
<#262 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVBAYVWHHHH4XYTOOWDXB72Q5ANCNFSM6AAAAAAXEDRTPA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Lucas: |
|
Hi, Kate. Let's call the new option "fast_tau_w_sec" and deprecate the old
one (add a check in fv_control_mod::fv_init() to throw a warning message if
tau_w > 0), since the older one is much less effective than the new one.
The name "fast" would be a useful mnemonic to remind the user that the
timescale is in seconds and not days.
Thanks
Lucas
…On Wed, Apr 19, 2023 at 12:24 PM XiaqiongZhou-NOAA ***@***.***> wrote:
Lucas:
In the current dev/emc, if tau_w=0, w is damped as tau. The purpose of
tau_w is to have different damping time scale for horizontal and vertical
winds. I am not sure who is currently using this option. This option was
added based on Henry's test for WAM at that time.
Kate
—
Reply to this email directly, view it on GitHub
<#262 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVCFQKDZE4URGZGSJPLXCAGT5ANCNFSM6AAAAAAXEDRTPA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Lucas: Lauren: |
|
I have just pushed the changes, let me know if that is acceptable |
|
Hi, Lauren. These changes look good to me. Thanks for taking care of this. Lucas |
| pe2, dm, & | ||
| pm2, pem, w2, dz2, pt(is:ie,j,1:km), ws(is,j), & | ||
| a_imp, p_fac, scale_m) | ||
| a_imp, p_fac, scale_m, tau_w) |
There was a problem hiding this comment.
tau_w added in nh_core.F90, nh_utils.F90 should be fast_tau_w_sec
There was a problem hiding this comment.
Hi, Kate. I believe that inside the nh_core/nh_utils modules the name is tau_w and the namelist flag fast_tau_w_sec is used in the call to the NH utils. So this implementation is correct, but potentially confusing. However for consistency's sake and to eliminate confusion we could replace this with fast_tau_w_sec.
Thanks,
Lucas
There was a problem hiding this comment.
I will update this also to use fast_tau_w_sec as well. You are right that this could be confusing to follow.
…lculation to be fully double precsision. Address spacing change.
|
Comments from PR #261 and this PR have all now been addressed. Changes are identical in both PRs. |
|
Hi, Lauren. This is really great. Thank you so much.
Lucas
…On Thu, Apr 20, 2023 at 8:54 AM laurenchilutti ***@***.***> wrote:
Comments from PR #261
<#261> and this
PR have all now been addressed. Changes are identical in both PRs.
—
Reply to this email directly, view it on GitHub
<#262 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVERZSRDJASD4IOQNW3XCEWXHANCNFSM6AAAAAAXEDRTPA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
replacing this PR with #266 |
3 participants
Description
Cherry-picks changes form PR #261 to dev/emc
This includes updates on behalf of Lucas Harris including:
Revision to semi-implicit solver to linearize vertical sound wave propagation about the hydrostatic state. This has been extensively tested by GFDL and EMC in SHiELD, GFS, and RRFS.
Fixes # (issue)
How Has This Been Tested?
This has been tested with ShiELD in the main branch.
Checklist:
Please check all whether they apply or not