Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
1dc9699
Initial commit of the fms_diag_object_container. Includes the underlying
Dec 6, 2021
02c9f53
Modified diag object iterator to fix casting compilation error on CI …
Dec 7, 2021
6275892
Initial modificationss in response to a review by Tom Robinsom
Dec 8, 2021
5da33c2
Experimenting with documentation annotations.
Dec 8, 2021
3ec00fc
Added test of fms_diag_object_container class. Further changes to fol…
Dec 9, 2021
a5ed9d4
Corrected script calling unit test. Added todo in fms_diag_yaml.F90.
Dec 9, 2021
687aac6
Cleaned up test of container.
Dec 9, 2021
7044c9f
Addded a "TODO:" to fms_diag_yaml.F90, function is filed type null.
Dec 9, 2021
df06cc7
Modified new files and unit test for further compliance with coding s…
Dec 13, 2021
8984a3b
Renamed the linked list mod. Corrected CMakeList.txtx and a Makefile.am.
Dec 13, 2021
5b398ea
Renamed linked list mod. Changed a Makefile.am.
Dec 13, 2021
d826d8c
Fixed CMakeLists.txt.
Dec 13, 2021
d9265fa
Mods to CMakeLIst.txt. Includes adding parser dir files.
Dec 13, 2021
63c201d
Fixing typo in CMakeLists.txt
Dec 13, 2021
a875a70
Many comments and documentation chages based on Tom R's 2nd review.
Dec 14, 2021
c76a694
Adds annotations @addtogroup and @{ to the diag object container mod …
Dec 15, 2021
5552836
Added comments for the "this" variable. Nods to use "!<" for var comm…
Dec 16, 2021
2d2af7d
Further doxygen related improvements. Some improvements on on calss a…
Dec 17, 2021
0684562
Merge remote-tracking branch 'upstream/dmUpdate' into dmUpdate
Dec 17, 2021
7bb5c07
Five chages of list node instance declarations from class to node to
Dec 17, 2021
47814e8
One change from type to class for an interator instance. Some comment…
Dec 17, 2021
025ccfd
Added test_diag_dlinked_list.F90. Modified memeber data/access in sev…
Dec 21, 2021
64ca1fa
Improved or added several comments.
Dec 21, 2021
571041c
Removed vs code related files.
Dec 21, 2021
cb2530e
Removing extraneous return statement in test_diag_dlinked_list.F90.
Dec 22, 2021
77a5960
Improved test_diag_dlinked_list.F90, both code and comments.
Dec 22, 2021
c00b6a3
Merge remote-tracking branch 'upstream/dmUpdate' into dmUpdate
Dec 29, 2021
bbef9c6
Removed duplicate yaml_parser.F90 from CMakeLists.txt.
Jan 3, 2022
415a38a
Incorporates changes based on Tom R's latest review.
Jan 4, 2022
8682eda
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Jan 4, 2022
1fb5a63
Merge branch 'dmUpdate' of https://github.com/ngs333/FMS into dmUpdate
Jan 4, 2022
01dec84
Includes some doxygen related changes requested by Ryan M.
Jan 4, 2022
2e4a42f
Skipping linked list and the container tests by adding skip arg to ca…
Jan 7, 2022
0b97a47
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
Jan 7, 2022
5ee91f6
Fixes the core dump of test_diag_dlinked_list. Also does some
Jan 13, 2022
85a3af0
Improved comments, especially destructor and clear function.
Jan 14, 2022
c6a034f
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
Jan 14, 2022
303a002
Modified diag_manager to the containers initialize routine.
Jan 14, 2022
9be5617
Post review making sure member vars are private.
Jan 25, 2022
f73e69d
Renamed linked list node member "data" to "data_ptr".
Feb 1, 2022
ba6f259
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Feb 11, 2022
5f55587
Changing script test_diag_manager2.sh to enable testing of linked lis…
Feb 17, 2022
a275a5c
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Feb 25, 2022
1001b7f
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Feb 25, 2022
5dc8ea9
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Feb 25, 2022
714cde0
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Mar 1, 2022
9667597
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Mar 2, 2022
012b4c3
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Mar 8, 2022
6050e28
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Mar 14, 2022
b1a6756
Added fms_send_data_statfun_mod files.
Mar 16, 2022
c564c0d
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Mar 21, 2022
fee62d4
Added 1D and 3D functions to weight the field. Functions can be selected
Mar 23, 2022
6fd12a1
More improvements to fms_send_data_statfun.F90
Mar 28, 2022
00065a7
Completed replacement of innermost check with use of function pointer.
Mar 29, 2022
78ee398
COmpleted use of ASSOCIATE construct for buffer and counter.
Mar 29, 2022
d0ce230
Added Fortran if-then construct labels.
Apr 12, 2022
40702b0
Merge remote-tracking branch 'upstream/dmUpdate' into dmUpdate
Apr 12, 2022
6c2059d
Extracted some send_data_ed functionality into new function
Apr 13, 2022
6139fe4
Reducing line lengths below 120 for fms_send_data_statfun.F90
Apr 13, 2022
aa58af1
Adding fms_send_data_statfun.F90 to CMakeLists.txt
Apr 13, 2022
e67c10c
Fixing typo in CMakeLists.txt
Apr 13, 2022
81e82fa
Addiing to use statements of fms_send_data_statfun module.
Apr 13, 2022
c2e74da
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Apr 26, 2022
22db057
First version passing diag_manager unit test 17
Apr 26, 2022
4550cdc
Merge branch 'dmUpdate' of https://github.com/ngs333/FMS into dmUpdate
Apr 26, 2022
266c055
Checking further labels on IF construct.
May 2, 2022
8e7a73d
Added more labels to IF constructs.
May 3, 2022
5dbee97
Moved averaging functions to own module and added configuration class
May 4, 2022
bb400fa
Fixing CMakeLists.txt. Splitting lines greater than 120 chars.
May 4, 2022
65246e2
Added more if construct labels.
May 13, 2022
52dbb8a
Splitting code lines so they are at most 120 chars.
May 13, 2022
b39a565
Changed names in fms_diag_weight_procs, e.g. weigh_field_x to
May 14, 2022
820788e
Added documentation.
May 14, 2022
05fbec0
Added test new tests for send_data_statfun.
May 17, 2022
31cc10f
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
May 17, 2022
9cec9b8
Adding use of platform mod to diag_weight_procs mod. Correcting
May 17, 2022
05cbb83
Fixed alloc in tests_send_data_statfun. Allows make check test to com…
May 17, 2022
80d9f1d
Contains first working version of test_send_data_statfun.
May 17, 2022
cb44651
Fixing dependency of of send_data_statfun_mod in Makefile.am.
May 19, 2022
97569a8
Removing return statement from test program.
May 19, 2022
82b3c0c
Changing type of err message char array to pass compilation by Intel …
May 19, 2022
e18e790
Averaging funcs and their cfg now in one module.
Jun 3, 2022
2ea4ada
fixing average_the_filed after moving its config info.
Jun 4, 2022
784f272
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
Jun 4, 2022
c73f34f
Fixing two typos.
Jun 4, 2022
c0defa4
Re-formatting send_data_statfun.F90 file.
Jun 4, 2022
0613220
Both new and older send_data_statfun working. Fixed test numbers/coun…
Jun 6, 2022
5c1da6d
Removed 1st working version of send_data_statfun_mod; leaving
Jun 6, 2022
377d4f9
Fixing makefile.am.
Jun 6, 2022
a86ac21
Removing reference to old module (weight procs).
Jun 6, 2022
1c2e349
Fixing length of err_msg_local.
Jun 6, 2022
75bea2c
Modified interface of check_out_of_bounds and update_bounds functions of
Jun 10, 2022
c8559ca
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Jun 10, 2022
3a82bb3
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
Jun 22, 2022
d54369d
Changed interface of averaging functions to accept more arguments in
Jun 22, 2022
29d367f
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
Jul 6, 2022
9285cdf
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Jul 12, 2022
f7e5f9a
Merge branch 'NOAA-GFDL:dmUpdate' into dmUpdate
ngs333 Jul 18, 2022
a3a1d5c
Merge branch 'dmUpdate' of https://github.com/NOAA-GFDL/FMS into dmUp…
Jul 18, 2022
30b1457
Merge branch 'dmUpdate' of https://github.com/ngs333/FMS into dmUpdate
Jul 18, 2022
807888b
Compiling post merge of 2022.03-beta1 with dmUpdate. Has fix for DM u…
Jul 18, 2022
058983f
Removed VSCode config files.
Jul 18, 2022
ee4521f
Merge remote-tracking branch 'upstream/dmUpdate' into dmUpdate
Jul 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions diag_manager/fms_diag_object.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1078,8 +1078,8 @@ INTEGER FUNCTION fms_register_static_field(module_name, field_name, axes, long_n
CHARACTER(len=*), OPTIONAL, INTENT(in) :: long_name !< Longname to be added as a attribute
CHARACTER(len=*), OPTIONAL, INTENT(in) :: units !< Units to be added as a attribute
CHARACTER(len=*), OPTIONAL, INTENT(in) :: standard_name !< Standard name to be added as a attribute
class(*), OPTIONAL, INTENT(in) :: missing_value !< Missing value to be added as a attribute
class(*), DIMENSION(:), OPTIONAL, INTENT(in) :: range !< Range to be added as a attribute
CLASS(*), OPTIONAL, INTENT(in) :: missing_value !< Missing value to be added as a attribute
CLASS(*), OPTIONAL, INTENT(in) :: range(:) !< Range to be added as a attribute
LOGICAL, OPTIONAL, INTENT(in) :: mask_variant !< Flag indicating if the field is has
!! a mask variant
LOGICAL, OPTIONAL, INTENT(in) :: DYNAMIC !< Flag indicating if the field is dynamic
Expand Down
9 changes: 8 additions & 1 deletion test_fms/diag_manager/test_diag_manager2.sh
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ setup_test
test_expect_success "Unstructured grid (test $my_test_count)" '
mpirun -n 1 ../test_diag_manager
'

my_test_count=24
# test_diag_manager_time
cat <<_EOF > diag_table
test_diag_manager
Expand Down Expand Up @@ -494,6 +494,7 @@ test_diag_manager
"test_diag_manager_mod", "ice", "ice", "test_diurnal", "all", "diurnal3", "none", 2
_EOF

my_test_count=25
test_expect_success "diurnal test (test $my_test_count)" '
mpirun -n 1 ../test_diag_manager_time
'
Expand Down Expand Up @@ -576,6 +577,7 @@ diag_files:
_EOF
cp diag_table.yaml diag_table.yaml_base

my_test_count=26
test_expect_success "diag_yaml test (test $my_test_count)" '
mpirun -n 1 ../test_diag_yaml
'
Expand Down Expand Up @@ -627,10 +629,13 @@ diag_files:
reduction: average
kind: r4
_EOF

my_test_count=41
test_expect_success "Test the diag_ocean feature in diag_manager_init (test $my_test_count)" '
mpirun -n 2 ../test_diag_ocean
'

my_test_count=42
test_expect_success "test_diag_dlinked_list (test $my_test_count)" '
mpirun -n 1 ../test_diag_dlinked_list
'
Expand Down Expand Up @@ -701,7 +706,9 @@ diag_files:
kind: r4
_EOF

my_test_count=43
test_expect_success "Test the modern diag manager end to end (test $my_test_count)" '
mpirun -n 6 ../test_modern_diag
'

test_done