Fixes for linter action by rem1776 · Pull Request #869 · NOAA-GFDL/FMS

rem1776 · 2021-12-10T21:07:39Z

Description
Updates the linter so it'll work correctly and cleans up the code so that it'll pass.

Most files had lines over the max length of 120 (it's really 119 since \n''s are counted) so the majority of the changes are line length fixes done mostly with a script.

How Has This Been Tested?
passed make distcheck with gcc 9 and intel 19

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
New check tests, if applicable, are included
make distcheck passes

thomas-robinson · 2022-01-05T18:34:47Z

This needs to be tested with a model before I will approve it. There is a LOT of code changes. Can you run the aquaplanet with this branch?

rem1776 · 2022-01-06T15:13:31Z

@thomas-robinson Tested it with aquaplanet, no issues

thomas-robinson

There are inconsistencies with spacing and &s, but nothing that I see that is bad. I made a few comments, but I don't think anything really needs to be addresed.

thomas-robinson · 2022-03-01T13:49:47Z

                ksr= l_start(3)
                ker= l_end(3)
-                WHERE ( field(f1:f2,f3:f4,ksr:ker) < output_fields(out_num)%buffer(is-hi:ie-hi,js-hj:je-hj,:,sample) ) &
+                WHERE ( field(f1:f2,f3:f4,ksr:ker) < output_fields(out_num)%buffer(is-hi:ie-hi,js-hj:je-hj,:,sample) )&


this isn't consistent with the change made on line 2815

thomas-robinson · 2022-03-01T13:50:35Z

                      DO i = is, ie
-                         IF ( l_start(1)+hi <= i .AND. i <= l_end(1)+hi .AND. l_start(2)+hj <= j .AND. j <= l_end(2)+hj ) THEN
+                         IF ( l_start(1)+hi <= i .AND. i <= l_end(1)+hi .AND. l_start(2)+hj <= j .AND. &
+                            & j <= l_end(2)+hj ) THEN


This isn't consistent with the change made on 2943

thomas-robinson · 2022-03-01T14:28:53Z

+!>  Based on mpp_define_nest_domains, but just resets positioning of nest
 !>    Modifies the parent/coarse start and end indices of the nest location
 !!    Computes new overlaps of nest PEs on parent PEs
 !!    Ramstrom/HRD Moving Nest


Why is there so much white space here?

thomas-robinson · 2022-03-01T17:59:09Z

 !   </TEMPLATE>
 !   <TEMPLATE>
-!     6. call time_interp( Time, Time_beg, Time_end, Timelist, weight, index1, index2 [,correct_leap_year_inconsistency])
+! 6. call time_interp( Time, Time_beg, Time_end, Timelist, weight, index1, index2 [,correct_leap_year_inconsistency])


This no longer lines up with the other sequenced numbers

thomas-robinson · 2022-03-01T18:00:38Z

+    ' It must begin with: "years since", "months since", "days since", "hours since", "minutes since", &
+            &  or "seconds since"',FATAL)


This is inconsistent with how you have dealt with other strings in multi-line instances

The script got messed up with this line actually so this is fixed to add the concatenation

* get_unit warning now only prints on root_pe (NOAA-GFDL#872) Co-authored-by: Eric Stofferahn <Eric.Stofferahn@noaa.gov> * Update changelog, version numbers and build info (NOAA-GFDL#873) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> * chore: Change version number to next development version (NOAA-GFDL#874) * CI: Update build action for yaml parser (NOAA-GFDL#871) Update build actions Change images to organization's repo and fix mixed mode parser test failure * test(parser): Change real comparison value to double (NOAA-GFDL#886) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> * Make 'unsupported kind' error messages more descriptive. Change author of constants4.F90 * Add doxygen comment to valid_types in sat_vapor_pres/sat_vapor_pres_k.F90 * Modify codes for r8-r4 conversion to remove compiler warnings * Remove OVERLOAD_R8 directives regarding send_data_*d_r8 subroutines * Add Doxygen comments to constants4.F90 * Updates AM4 regression test suite to run intel 21 only on PW (NOAA-GFDL#893) * feat: emc changes for mixedmode (NOAA-GFDL#857) (NOAA-GFDL#898) * Change send_data interface and any necessary routines for mixed real precision support * Adds an r4 size constants file BREAKING CHANGE: changes some argument types in diag_manager, tracer_manager, sat_vapor_pres, and time_manager from real to class(*) Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com> * feat: adds option to override (ignore) checksum test when reading restarts (NOAA-GFDL#889) * update to fms2_io to allow reads to ignore embedded checksums on a fileobj basis * added fms2_io test cases for the ignore_checksum option to restart reads tests the domain, domain_wrap, and bc restart options * docs: add CI information file (NOAA-GFDL#899) * test: Adds check_nml_error after reading a namelist, so it could crash only as expected (NOAA-GFDL#904) * Revert "feat: emc changes for mixedmode (NOAA-GFDL#857) (NOAA-GFDL#898)" (NOAA-GFDL#914) This reverts commit 516a5ef. * fix: clean up unused/uninitialized variables and other warnings (NOAA-GFDL#859) Remove unused variables throughout and changes/removals for other warnings such as uninitialized values and implicit casts * docs: update function style and branch names * Changes master to main in CONTRIBUTING.md * Claifies function return documentation in CODE_STYLE.md * feat: adds support for logical variables in the yaml parser (NOAA-GFDL#907) * Adds support for logical variables in the yaml parser * correctly determines if a string is true or false * fix: add check for affinity to self-initialize and update test program (NOAA-GFDL#917) * fix: adds casts to class(*) calls to match doubles in C routines (NOAA-GFDL#920) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> * build: add intel code coverage build option to autotools (NOAA-GFDL#895) * refactor: change to inclusive variable names (NOAA-GFDL#926) * feat: Allow maximum number of restart variables to be set at build time (NOAA-GFDL#909) * fix: Fixes for linter action and code style (NOAA-GFDL#869) * test: Test script updates and input tests (NOAA-GFDL#800) Rewrites test script to use added testing shell functions Adds previously skipped or removed unit tests and support for testing with input files Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: Uriel Ramirez <uriel.ramirez@noaa.gov> * chore: 2022.01 release changes (NOAA-GFDL#941) * chore: change version number to next development version (NOAA-GFDL#945) * Add option for position independent code (NOAA-GFDL#930) * fix: document and change parameter names for grid versions (NOAA-GFDL#918) * fix: Moving empty and non-existent data table handling inside data_override (NOAA-GFDL#933) Enables the processing of an empty or non-existent data_table or data_table.yaml from within data_override, so that any routine can call data_override_init without worry * fix: Removal of internal FMS use of fms_io and mpp_io (NOAA-GFDL#928) * fix: mpp changes to solve compile issues with serial builds (NOAA-GFDL#949) * feat: adds build option for compiling with different sets of constants (NOAA-GFDL#929) * feat: add and aggregate mpp_chksum unit tests (NOAA-GFDL#946) * feat: add module for string utility routines (NOAA-GFDL#911) Adds module and accompanying test for common string operations * revert: reinstated the mpp_io routines and put them at the end for future elimination. (NOAA-GFDL#952) * fix: add back in small_fac parameter to constants .h files (NOAA-GFDL#954) * fix: root pe bug with fms2_io::flush_file (NOAA-GFDL#958) * fix: clean up string routines for fms_string_utils_mod (NOAA-GFDL#953) * Make changes to lines with more than 120 columns Co-authored-by: Ryan Mulhall <35538242+rem1776@users.noreply.github.com> Co-authored-by: Eric Stofferahn <Eric.Stofferahn@noaa.gov> Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Tom Robinson <33458882+thomas-robinson@users.noreply.github.com> Co-authored-by: Rusty Benson <6594772+bensonr@users.noreply.github.com> Co-authored-by: uramirez8707 <49168881+uramirez8707@users.noreply.github.com> Co-authored-by: Raffaele Montuoro <raffaele.montuoro@outlook.com> Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: Uriel Ramirez <uriel.ramirez@noaa.gov> Co-authored-by: Matthew Thompson <matthew.thompson@nasa.gov> Co-authored-by: Eric <7784797+GFDL-Eric@users.noreply.github.com>

* get_unit warning now only prints on root_pe (NOAA-GFDL#872) Co-authored-by: Eric Stofferahn <Eric.Stofferahn@noaa.gov> * Update changelog, version numbers and build info (NOAA-GFDL#873) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> * chore: Change version number to next development version (NOAA-GFDL#874) * CI: Update build action for yaml parser (NOAA-GFDL#871) Update build actions Change images to organization's repo and fix mixed mode parser test failure * test(parser): Change real comparison value to double (NOAA-GFDL#886) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> * Make 'unsupported kind' error messages more descriptive. Change author of constants4.F90 * Add doxygen comment to valid_types in sat_vapor_pres/sat_vapor_pres_k.F90 * Modify codes for r8-r4 conversion to remove compiler warnings * Remove OVERLOAD_R8 directives regarding send_data_*d_r8 subroutines * Add Doxygen comments to constants4.F90 * Updates AM4 regression test suite to run intel 21 only on PW (NOAA-GFDL#893) * feat: emc changes for mixedmode (NOAA-GFDL#857) (NOAA-GFDL#898) * Change send_data interface and any necessary routines for mixed real precision support * Adds an r4 size constants file BREAKING CHANGE: changes some argument types in diag_manager, tracer_manager, sat_vapor_pres, and time_manager from real to class(*) Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com> * feat: adds option to override (ignore) checksum test when reading restarts (NOAA-GFDL#889) * update to fms2_io to allow reads to ignore embedded checksums on a fileobj basis * added fms2_io test cases for the ignore_checksum option to restart reads tests the domain, domain_wrap, and bc restart options * docs: add CI information file (NOAA-GFDL#899) * test: Adds check_nml_error after reading a namelist, so it could crash only as expected (NOAA-GFDL#904) * Revert "feat: emc changes for mixedmode (NOAA-GFDL#857) (NOAA-GFDL#898)" (NOAA-GFDL#914) This reverts commit 516a5ef. * fix: clean up unused/uninitialized variables and other warnings (NOAA-GFDL#859) Remove unused variables throughout and changes/removals for other warnings such as uninitialized values and implicit casts * docs: update function style and branch names * Changes master to main in CONTRIBUTING.md * Claifies function return documentation in CODE_STYLE.md * feat: adds support for logical variables in the yaml parser (NOAA-GFDL#907) * Adds support for logical variables in the yaml parser * correctly determines if a string is true or false * fix: add check for affinity to self-initialize and update test program (NOAA-GFDL#917) * fix: adds casts to class(*) calls to match doubles in C routines (NOAA-GFDL#920) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> * build: add intel code coverage build option to autotools (NOAA-GFDL#895) * refactor: change to inclusive variable names (NOAA-GFDL#926) * feat: Allow maximum number of restart variables to be set at build time (NOAA-GFDL#909) * fix: Fixes for linter action and code style (NOAA-GFDL#869) * test: Test script updates and input tests (NOAA-GFDL#800) Rewrites test script to use added testing shell functions Adds previously skipped or removed unit tests and support for testing with input files Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: Uriel Ramirez <uriel.ramirez@noaa.gov> * chore: 2022.01 release changes (NOAA-GFDL#941) * chore: change version number to next development version (NOAA-GFDL#945) * Add option for position independent code (NOAA-GFDL#930) * fix: document and change parameter names for grid versions (NOAA-GFDL#918) * fix: Moving empty and non-existent data table handling inside data_override (NOAA-GFDL#933) Enables the processing of an empty or non-existent data_table or data_table.yaml from within data_override, so that any routine can call data_override_init without worry * fix: Removal of internal FMS use of fms_io and mpp_io (NOAA-GFDL#928) * fix: mpp changes to solve compile issues with serial builds (NOAA-GFDL#949) * feat: adds build option for compiling with different sets of constants (NOAA-GFDL#929) * feat: add and aggregate mpp_chksum unit tests (NOAA-GFDL#946) * feat: add module for string utility routines (NOAA-GFDL#911) Adds module and accompanying test for common string operations * revert: reinstated the mpp_io routines and put them at the end for future elimination. (NOAA-GFDL#952) * fix: add back in small_fac parameter to constants .h files (NOAA-GFDL#954) * fix: root pe bug with fms2_io::flush_file (NOAA-GFDL#958) * fix: clean up string routines for fms_string_utils_mod (NOAA-GFDL#953) * chore: update libFMS module with new routines (NOAA-GFDL#912) * fix: removes fms_c.c and fms_c.h (NOAA-GFDL#961) * Make changes to lines with more than 120 columns Co-authored-by: Ryan Mulhall <35538242+rem1776@users.noreply.github.com> Co-authored-by: Eric Stofferahn <Eric.Stofferahn@noaa.gov> Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Tom Robinson <33458882+thomas-robinson@users.noreply.github.com> Co-authored-by: Rusty Benson <6594772+bensonr@users.noreply.github.com> Co-authored-by: uramirez8707 <49168881+uramirez8707@users.noreply.github.com> Co-authored-by: Raffaele Montuoro <raffaele.montuoro@outlook.com> Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: Uriel Ramirez <uriel.ramirez@noaa.gov> Co-authored-by: Matthew Thompson <matthew.thompson@nasa.gov> Co-authored-by: Eric <7784797+GFDL-Eric@users.noreply.github.com>

rem1776 added 6 commits December 7, 2021 17:47

Fix lengths in first few directories

d183213

More line length fixes

27568ee

More line fixes

e904271

Fix last files - 1

02aef1b

Fix last file

2f01071

Clean up

a9e4864

rem1776 requested review from bensonr, thomas-robinson and wrongkindofdoctor as code owners December 10, 2021 21:07

Merge remote-tracking branch 'upstream/main' into linter

003f1de

wrongkindofdoctor previously approved these changes Dec 22, 2021

View reviewed changes

rem1776 added 2 commits January 7, 2022 13:09

Merge remote-tracking branch 'upstream/main' into linter

492692c

Fix line length for added test

d57a06f

rem1776 dismissed wrongkindofdoctor’s stale review via d57a06f January 10, 2022 16:57

rem1776 and others added 4 commits January 12, 2022 12:25

Merge branch 'main' into linter

6fd13fb

Merge remote-tracking branch 'upstream/main' into linter

9cd0f6a

Whitespace fixes

f90208a

Merge remote-tracking branch 'upstream/main' into linter

be8bfcc

thomas-robinson previously approved these changes Mar 1, 2022

View reviewed changes

rem1776 added 2 commits March 1, 2022 16:03

Merge remote-tracking branch 'upstream/main' into linter

4335753

Fix a string and add an &

eb8df99

rem1776 dismissed thomas-robinson’s stale review via eb8df99 March 1, 2022 21:15

thomas-robinson approved these changes Mar 3, 2022

View reviewed changes

rem1776 merged commit 6deed0a into NOAA-GFDL:main Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for linter action#869

Fixes for linter action#869
rem1776 merged 15 commits into
NOAA-GFDL:mainfrom
rem1776:linter

rem1776 commented Dec 10, 2021

Uh oh!

thomas-robinson commented Jan 5, 2022

Uh oh!

rem1776 commented Jan 6, 2022

Uh oh!

thomas-robinson left a comment

Uh oh!

thomas-robinson Mar 1, 2022

Uh oh!

thomas-robinson Mar 1, 2022

Uh oh!

thomas-robinson Mar 1, 2022

Uh oh!

thomas-robinson Mar 1, 2022

Uh oh!

thomas-robinson Mar 1, 2022

Uh oh!

rem1776 Mar 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		' It must begin with: "years since", "months since", "days since", "hours since", "minutes since", &
		& or "seconds since"',FATAL)

Conversation

rem1776 commented Dec 10, 2021

Uh oh!

thomas-robinson commented Jan 5, 2022

Uh oh!

rem1776 commented Jan 6, 2022

Uh oh!

thomas-robinson left a comment

Choose a reason for hiding this comment

Uh oh!

thomas-robinson Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

thomas-robinson Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

thomas-robinson Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

thomas-robinson Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

thomas-robinson Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

rem1776 Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants