Bring EMC fms_mixedmode up to date with GFDL main#15
Merged
MinsukJi-NOAA merged 47 commits intoApr 15, 2022
Conversation
Co-authored-by: Eric Stofferahn <Eric.Stofferahn@noaa.gov>
Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
Update build actions Change images to organization's repo and fix mixed mode parser test failure
Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
…r of constants4.F90
* Change send_data interface and any necessary routines for mixed real precision support * Adds an r4 size constants file BREAKING CHANGE: changes some argument types in diag_manager, tracer_manager, sat_vapor_pres, and time_manager from real to class(*) Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com>
…tarts (NOAA-GFDL#889) * update to fms2_io to allow reads to ignore embedded checksums on a fileobj basis * added fms2_io test cases for the ignore_checksum option to restart reads tests the domain, domain_wrap, and bc restart options
…h only as expected (NOAA-GFDL#904)
…" (NOAA-GFDL#914) This reverts commit 516a5ef.
…-GFDL#859) Remove unused variables throughout and changes/removals for other warnings such as uninitialized values and implicit casts
* Changes master to main in CONTRIBUTING.md * Claifies function return documentation in CODE_STYLE.md
…L#907) * Adds support for logical variables in the yaml parser * correctly determines if a string is true or false
…A-GFDL#920) Co-authored-by: rem1776 <Ryan.Mulhall@lscamd50-d.gfdl.noaa.gov>
Rewrites test script to use added testing shell functions Adds previously skipped or removed unit tests and support for testing with input files Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: Uriel Ramirez <uriel.ramirez@noaa.gov>
…erride (NOAA-GFDL#933) Enables the processing of an empty or non-existent data_table or data_table.yaml from within data_override, so that any routine can call data_override_init without worry
Adds module and accompanying test for common string operations
…ture elimination. (NOAA-GFDL#952)
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
There are a lot of changes, are there any conflicts with the mixed-mode code updates?
Collaborator
Author
There were two files with conflicts: |
Collaborator
Author
|
One of the Github Actions tests failed with this message: Will fix this. |
junwang-noaa
approved these changes
Apr 15, 2022
binli2337
approved these changes
Apr 15, 2022
Collaborator
Author
|
All GitHub Actions tests passed (except the one using parallelWorks) with the latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses