-
Notifications
You must be signed in to change notification settings - Fork 162
Adds routine init_mask_3d() to diag_util_mod #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomas-robinson
merged 5 commits into
NOAA-GFDL:dmUpdate
from
ganganoaa:init_mask_dmUpdate
May 10, 2023
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d52287b
Adds routine fms_diag_init_mask_3d() to fms_diag_object_mod
ganganoaa d07b6bc
Move fms_diag_init_mask_3d() from fms_diag_object_mod to diag_util_mod
ganganoaa 4d30fcd
Merge branch 'dmUpdate' into init_mask_dmUpdate
ganganoaa f398f62
Update diag_util.F90
ganganoaa 734ba94
Merge branch 'dmUpdate' into init_mask_dmUpdate
ganganoaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a fmsDiagObject_type procedure and does not used the type at all. It should be somewhere else. Do you want to start a new file (fms_diag_util.F90) for these small procedures, or put them in diag_util, or make this a type bound procedure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will put them in diag_util_mod.