Adds routine init_mask_3d() to diag_util_mod#1201
Merged
thomas-robinson merged 5 commits intoMay 10, 2023
Merged
Conversation
thomas-robinson
requested changes
Apr 26, 2023
| !> @brief Allocates outmask(second argument) with sizes of first three dimensions of field(first argument). | ||
| !! Initializes the outmask depending on presence/absence of inmask and rmask. | ||
| !! Uses and sets rmask_threshold. | ||
| subroutine fms_diag_init_mask_3d(field, outmask, rmask_threshold, inmask, rmask) |
Member
There was a problem hiding this comment.
This is not a fmsDiagObject_type procedure and does not used the type at all. It should be somewhere else. Do you want to start a new file (fms_diag_util.F90) for these small procedures, or put them in diag_util, or make this a type bound procedure?
Contributor
Author
There was a problem hiding this comment.
I will put them in diag_util_mod.
ganganoaa
changed the title
thomas-robinson
approved these changes
May 10, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* Adds routine fms_diag_init_mask_3d() to diag_util_mod
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* Adds routine fms_diag_init_mask_3d() to diag_util_mod
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a generic public routine, init_mask_3d(), to the diag_util_mod which will be used to initialize a local logical mask variable.
Fixes # (issue)
CI
How Has This Been Tested?
N/A
Checklist:
make distcheckpasses