Major cleanup of CCPP cmake build config#436
Merged
junwang-noaa merged 6 commits intoDec 14, 2021
Merged
Conversation
This was referenced Dec 3, 2021
…anup_cmake_build_config_ccpp
DusanJovic-NOAA
approved these changes
Dec 6, 2021
…anup_cmake_build_config_ccpp
SamuelTrahanNOAA
approved these changes
Dec 7, 2021
Contributor
|
Remember to change the .gitmodules back! |
aerorahul
approved these changes
Dec 7, 2021
junwang-noaa
approved these changes
Dec 14, 2021
Collaborator
Author
|
Hashes are correct for ccpp-framework (64b5afd) and ccpp-physics (98ebf42), ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
ccpp/CMakeLists.txtonly to accommodate changes in the CCPP cmake config in the associated PRs below and to fix a bug in the current build config that passed-no-prec-div -no-prec-sqrtto all files in ccpp-physics, although it should have been passed only to files that are compiled in 64bit double precision.Issue(s) addressed
This PR is related to issue ufs-community/ufs-weather-model#945
Testing
See ufs-community/ufs-weather-model#943
Dependencies