Update SCM to the latest ccpp-physics main#287
Merged
Conversation
grantfirl
commented
Dec 15, 2021
| message (FATAL_ERROR "Unsupported platform, only Linux and MacOSX are supported at this time.") | ||
| endif() | ||
|
|
||
| # Build Options |
Collaborator
Author
There was a problem hiding this comment.
@climbfuji Would you take a quick look at these changes in CMakeLists.txt to see if they make sense? I basically copied the flag setting that you pointed to in ufs-weather-model/cmake/Intel.cmake and gnu.cmake and added the bit that sets CMAKE_Fortran_FLAGS_PHYSICS/DYNAMICS from ufs-weather-model/FV3/ccpp/CMakeLists.txt. I didn't attempt to do anything with the INSTALL command.
Collaborator
Author
climbfuji
approved these changes
Dec 22, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
The code changes look good. I haven't tested them myself, but if they pass the SCM regression tests then this is ready to go imho.
mkavulich
pushed a commit
that referenced
this pull request
May 12, 2022
Update SCM to the latest ccpp-physics main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request catches the SCM up to the latest ccpp-physics main as of Dec 16, 2021 and implements changes to be consistent with the fv3atm pull requests listed below.
Requires NCAR/ccpp-physics#813