ufs_public_release: update version number for CCPP, bugfix for samfdeepcnv.f#33
Merged
DusanJovic-NOAA merged 6 commits intoJan 12, 2020
Conversation
…ed variables, leads to crashes in debug mode
climbfuji
force-pushed
the
update_version_number_ccpp
branch
from
63cf607 to
842fd54
Compare
climbfuji
changed the title
Collaborator
Author
… documentation updates
… into update_version_number_ccpp
DusanJovic-NOAA
approved these changes
Jan 10, 2020
…ework and ccpp/physics
junwang-noaa
approved these changes
Jan 12, 2020
climbfuji
added a commit
to climbfuji/fv3atm
that referenced
this pull request
Apr 10, 2020
dtc/hwrf-physics: HWRF RRTMG (based on NOAA-EMC#33)
climbfuji
pushed a commit
to climbfuji/fv3atm
that referenced
this pull request
Jun 8, 2020
Cleanup of radiation (clouds) - microphysics interaction
spencerkclark
added a commit
to ai2cm/fv3gfs-fortran
that referenced
this pull request
Apr 28, 2023
This bumps the base Ubuntu image used to one with a version of 20.04. The pinned SHA makes things consistent with the base image we use when building the prognostic run in fv3net. Note that due to NOAA-EMC/ufsatm#33, the tests with the TKE-EDMF scheme active fail in debug mode. We currently mark them as expected failures. To demonstrate that answers do not change when we fix this bug, we run the coarse-graining tests in repro mode here and checkpoing the checksums. In a followup commit, we will fix the bug, unmark the relevant debug mode tests, but retain the repro mode tests to demonstrate that the tests still all pass without modifying those checksums. Finally in one last commit we will remove those temporary repro mode tests as well as their checksums, as they will no longer be needed. Because the serialize_image fails to build with the new compilers, we also elect to remove the infrastructure and tests associated with it.
spencerkclark
added a commit
to ai2cm/fv3gfs-fortran
that referenced
this pull request
Apr 28, 2023
This bumps the base Ubuntu image used to one with a version of 20.04. The pinned SHA makes things consistent with the base image we use when building the prognostic run in fv3net. Note that due to NOAA-EMC/ufsatm#33, the tests with the TKE-EDMF scheme active fail in debug mode. We currently mark them as expected failures. To demonstrate that answers do not change when we fix this bug, we run the coarse-graining tests in repro mode here and checkpoing the checksums. In a followup commit, we will fix the bug, unmark the relevant debug mode tests, but retain the repro mode tests to demonstrate that the tests still all pass without modifying those checksums. Finally in one last commit we will remove those temporary repro mode tests as well as their checksums, as they will no longer be needed. Because the serialize_image fails to build with the new compilers, we also elect to remove the infrastructure and tests associated with it.
spencerkclark
added a commit
to ai2cm/fv3gfs-fortran
that referenced
this pull request
Apr 28, 2023
This bumps the base Ubuntu image used to one with a version of 20.04. The pinned SHA makes things consistent with the base image we use when building the prognostic run in fv3net. Note that due to NOAA-EMC/ufsatm#33, the tests with the TKE-EDMF scheme active fail in debug mode. We currently mark them as expected failures. To demonstrate that answers do not change when we fix this bug, we run the coarse-graining tests in repro mode here and checkpoint the checksums. In a followup commit, we will fix the bug, unmark the relevant debug mode tests, but retain the repro mode tests to demonstrate that the tests still all pass without modifying those checksums. Finally in one last commit we will remove those temporary repro mode tests as well as their checksums, as they will no longer be needed. Because the serialize_image fails to build with the new compilers, we also elect to remove the infrastructure and tests associated with it.
spencerkclark
added a commit
to ai2cm/fv3gfs-fortran
that referenced
this pull request
Apr 28, 2023
It does allow us to add checksums for previously xfailed debug mode tests, however. See NOAA-EMC/ufsatm#33 for more details regarding the convection scheme bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.