Skip to content

ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f, update of scientific documentation#374

Merged
climbfuji merged 13 commits into
NCAR:ufs_public_releasefrom
climbfuji:update_version_number_and_authors
Jan 10, 2020
Merged

ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f, update of scientific documentation#374
climbfuji merged 13 commits into
NCAR:ufs_public_releasefrom
climbfuji:update_version_number_and_authors

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Dec 26, 2019 •
edited
Loading

  • update version number from 3.0.0 to 4.0.0
  • update author list in CMakeLists.txt
  • bugfix for samfdeepcnv.f to prevent crash when regression tests are run in DEBUG mode (use of uninitialized variables)
  • contains @mzhangw's update of the scientific documentation (Scientific documentation v4.0 for UFS public release #376)
    • note: I created a baseline before pulling in the scientific documentation changes and then verified that the code reproduced this baseline after pulling in the scientific documentation

@climbfuji climbfuji changed the title ufs_public_release: update version number and authors ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f Jan 7, 2020
@climbfuji climbfuji mentioned this pull request Jan 7, 2020
Merged
@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jan 7, 2020

Associated PRs:

NCAR/ccpp-framework#247
#374
NOAA-EMC/ufsatm#33
ufs-community/ufs-weather-model#25

This was referenced Jan 7, 2020
Merged
Merged
@ligiabernardet
Copy link
Copy Markdown
Collaborator

ligiabernardet commented Jan 7, 2020

Should the updates to the SciDoc be included in this PR or be submitted as a separate PR?

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jan 7, 2020

Separate, please.

@ligiabernardet
Copy link
Copy Markdown
Collaborator

ligiabernardet commented Jan 7, 2020 via email

llpcarson
llpcarson approved these changes Jan 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji climbfuji changed the title ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f ufs_public_release: update version number and authors, bugfix for samfdeepcnv.f, update of scientific documentation Jan 9, 2020
@climbfuji climbfuji merged commit 8c7c1f6 into NCAR:ufs_public_release Jan 10, 2020
@climbfuji climbfuji deleted the update_version_number_and_authors branch June 27, 2022 03:31
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
@bensonr
Updates to use FMS 2021.03 (NCAR#374)
2dc03c1 
* io/FV3GFS_io.F90 updated to use fms2_io
* atmos_model.F90 and ccpp/data/GFS_typefs.F90 updates to input_nml_file handling
* atmos_cubed_sphere submodule updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantfirl grantfirl Awaiting requested review from grantfirl

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

1 more reviewer

@llpcarson llpcarson llpcarson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@climbfuji @ligiabernardet @llpcarson @mzhangw