WORK IN PROGRESS: fv3atm changes for splitting physics group in SDF #276
Closed
climbfuji wants to merge 15 commits into
Closed
WORK IN PROGRESS: fv3atm changes for splitting physics group in SDF #276climbfuji wants to merge 15 commits into
climbfuji wants to merge 15 commits into
Conversation
…ove_zorl_interstitial
…ove_zorl_interstitial
…ove_zorl_interstitial
…ace composites from ocean to water
…ji/fv3atm into rename_surface_composites_ocean_water
…pt RRTMGP interstititals over from GFS_interstitial DDT
…osphere_physics, make corresponding adjustments in ccpp/driver/CCPP_driver.F90 and atmos_model.F90
This was referenced Apr 12, 2021
Collaborator
Author
|
Progress has stalled, and the code capabilities doen't seem to be required right now. Closing. |
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Sep 29, 2023
LarissaReames
pushed a commit
to LarissaReames/fv3atm
that referenced
this pull request
Nov 17, 2023
…ength-mismatch initialize two arrays and fix fortran coding error plus PRs NOAA-EMC#285 and NOAA-EMC#276
zhanglikate
pushed a commit
to zhanglikate/ufsatm
that referenced
this pull request
Oct 7, 2025
…sics, and string length mismatch in dycore (plus PR #1913, #1917, and #1926) (#1893) * GFDL_atmos_cubed_sphere: consistent string lengths in array * stop FV3_HRRR_c3 from crashing with gnu debug * 1hr forecast limit for conus13km_debug_qr * fv3atm: bug fix from Dusan to recover_fields crash * disable conus13km_debug_qr_gnu due to 25% failure rate on Hera * FV3 dycore: initialize srf_wnd_var2 and tracers_var3 arrays * enable conus13km_debug_qr_gnu * Fix race condition in GFS_phys_time_vary.fv3.F90 error detection * More bug fixes to GFS_phys_time_vary.fv3.F90: 1. detect empty errmsg from subroutines 2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90 * ccpp-physics: initialize errmsg & errflg in noahmp_tables.f90 * ccpp-physics: only read h2odata, ozdata and noahmp table when they are needed * "point to the dimension fix of smc for dust emission" * FV3: more dycore bug fixes from GFDL_atmos_cubed_sphere PR 285 * merge #1926 * merge GFDL_atmos_cubed_sphere NOAA-EMC#276 * bugfix: 12hr hrrr tests * add GAEA rocoto support * fv3: merge GF radar fixes * check that baseline directory exists and is non-empty --------- Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads-up
Note. Includes all the changes from #261 and #271, because this PR it will be merged afterwards and not having those PRs included in the development phase will lead to merge conflicts.
The commit history and changes will be much smaller once #261 and #271 are merged. The first PR that really belongs to this PR is 861a8c5.
Description
This PR contains the following changes:
GFS_suite_interstitialDDT that contains "persistent interstitial" variables (allocated for each block)ccpp/driver/CCPP_driver.F90andatmos_model.F90to call thesurface_physicsandatmosphere_physicsgroups instead of thephysicsgroup, currently hardcoded for theFV3_GFS_v16suiteIssue(s) addressed
n/a
Testing
See ufs-community/ufs-weather-model#516
Dependencies
NCAR/ccpp-physics#615
#276
ufs-community/ufs-weather-model#516