Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water#271
Closed
climbfuji wants to merge 12 commits into
Closed
Conversation
…ove_zorl_interstitial
…ove_zorl_interstitial
…ove_zorl_interstitial
…ace composites from ocean to water
This was referenced Apr 5, 2021
climbfuji
requested review from
DusanJovic-NOAA,
SMoorthi-emc,
ShanSunNOAA and
junwang-noaa
ShanSunNOAA
approved these changes
Apr 5, 2021
Collaborator
ShanSunNOAA
left a comment
ShanSunNOAA
left a comment
There was a problem hiding this comment.
I approve it. Thanks for cleaning up this portion, -Shan
ShanSunNOAA
approved these changes
Apr 5, 2021
Collaborator
ShanSunNOAA
left a comment
ShanSunNOAA
left a comment
There was a problem hiding this comment.
I approve it. Thanks for the cleaning up, -Shan
…ji/fv3atm into rename_surface_composites_ocean_water
This was referenced Apr 9, 2021
junwang-noaa
pushed a commit
that referenced
this pull request
Apr 15, 2021
…2 threading (#279) * changed .gitmodules to point to merra2 ccpp/physics * remove GFDL_atmos_cubed_sphere and ccpp-framework from .git module * remove IPD gfsphysics * Update .gitmodules and submodule pointer for ccpp-physics for code review and testing * Remove interstitial zorl composites * Update .gitmodules and submodule pointer fpor ccpp-physics for code review and testing * Remove or replace references to IPD in comments in atmos_model.F90 * Initialize Sfcprop%zorlx to clear_val instead of huge * Update submodule pointer for ccpp-physics * Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water * Rename Sfcprop%zorlw to Sfcprop%zorlwav * Rename Sfcprop%zorlo to Sfcprop%zorlw * update submodule pointer for ccpp-physics * Revert change to .gitmodules and update submodule pointer for ccpp-physics Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Collaborator
Author
|
Merged as part of #279, doesn't get flagged as merged automatically because we are doing squashed merges in fv3atm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames Fortran variables and CCPP standard names / long names of surface composites from "ocean" to "water", since these also contain lake points. For consistency, rename
Sfcprop%zorlotoSfcprop%zorlw.Note that this PR contains all the changes in #261. #261 can be merged independently before this PR, or as part of this PR. Note also that #261 renames the previously existing
Sfcprop%zorlwtoSfcprop%zorlwavso that the change presented here can be made. Doing this renaming in two steps ensures that there is no mixup of variables being used.Issue(s) addressed
Fixes NCAR/ccpp-physics#455.
Testing
For regression testing, see ufs-community/ufs-weather-model#508
Dependencies
NCAR/ccpp-physics#609
#271
ufs-community/ufs-weather-model#508