Cld perts#233
Merged
Merged
Conversation
merge in updates from emc version
update from EMC fork
update to NOAA-EMC fork
update with NOAA-EMC fork
Update with EMC fork
9 tasks
junwang-noaa
requested review from
ClaraDraper-NOAA,
DusanJovic-NOAA and
climbfuji
junwang-noaa
approved these changes
Mar 5, 2021
climbfuji
requested changes
Mar 5, 2021
climbfuji
reviewed
Mar 18, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me, will approve after ccpp-physics was merged and the submodule pointer / .gitmodules file are updated.
climbfuji
reviewed
Mar 19, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
ccpp-physics hash is correct, just need to revert the change to .gitmodules.
Collaborator
Author
|
@DomHeinzeller I think I got it now. |
DusanJovic-NOAA
approved these changes
Mar 21, 2021
christinaholtNOAA
added a commit
to NOAA-GSL/fv3atm
that referenced
this pull request
Jun 15, 2021
* Add NSSL 2-Moment Microphysics * Update data structures to handle the additional tracer species in NSSL microphysics * Add the code files for NSSL microphysics to the CCPP prebuild config * Add suite for NSSL microphysics * Add a CCPP suite to test NSSL microphysics * Initialize ice fluxes and add "tiice" array (#119) (1) Introducing a separate array "tiice" to store internal ice temperature. "tiice" will be added to phyf*nc output only when frac_grid=T. (2) When cplflx=T, initializing ice fluxes by PBL calculated values when fluxes from CICE are unavailable. (3) Adding frac_grid to namelist and no longer modifying it inside FV3GFS_io.F90. frac_grid=F by default. * Remove cheyenne.pgi from CCPP config (#117) remove cheyenne.pgi from CCPP config (ccpp/set_compilers.sh, ccpp/build_ccpp.sh) * develop: merge HWRF version of saSAS with GFS version (#93) * Merge branch 'man_hafs_sas_without_updates_of_dtc_develop_49b73a8f4149ca88f071dbaae81f1769b120f1e0' into HEAD * gfsphysics/physics/GFS_debug.F90: add capability to debug 1-d logical arrays * Clean up error messages in gfsphysics/GFS_layer/GFS_typedefs.F90 Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> * Merge GFDL FV3 dynamic core new (201912) version (#65) * Change 'mytile' to 'mygrid' corresponding to the change in atmos_cubed_sphere * GFS.v16.0.4 physics update (#128) * physics update from GFS.v16.0.4 * GFS.v16.0.4 physics udpate * remove whitespaces in sfc_diff.f * keep z0 unchanged in coupled mode in sfc_diff.f * fix IPD run * point to NCAR ccpp-physics branch Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Update for GFDL_atmos_cubed_sphere (dycore GNU bugfix) (#131) * Bugfix for regional runs when dycore is compiled in double precision (#133) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere * Update develop from gsd/develop 2020/06/30 (#134) - output of auxiliary arrays (2d, 3d) from CCPP to assist developers debugging their physics - correctly output 3-dim tendencies for t, u, v, qv, ozone from CCPP physics - mandatory changes for the CCPP framework updates to handle blocked data structures correctly: fix inconsistent use of `horizontal_dimension` (ix) versus `horizontal_loop_extent` (im) and other metadata corrections - remove old pset logic from `ccpp_prebuild_config.py` (was required for CCPP dynamic build) - updates to all suite definition files: change the order of interstitial schemes get_phi_fv3+GFS_suite_interstitial_3 and GFS_DCNV_generic_pre to match the logical flow (does not change the answer) - move CCPP physics initialization calls in `atmos_model.F90` so that the physics can see the data from the restart files at initialization time - add capability to read large-scale and small-scale orographic data when using GSL drag suite - add additional fields to restart files as required for GSL physics updates - new suite definition files for RAP and HRRR configurations - capability to call radiation for the first `nhfrad` physics time steps for cold starts, afterwards on the cycle defined by the radiation time step * Add regression tests with MULTI_GASES (#108) * Update suite_FV3_GFS_2017_fv3wam.xml * Remove unnecessary file from the CCPP prebuild configuration * Add TACC frontera configuration * Update to RAS in CCPP, update submodule pointer for ccpp-framework (CI tests) (NOAA-EMC#252) * Reactivate mass flux arrays * fix the argument list in inline_post_getattr and remove prints and post_gfs_stub.F90 * ccpp/data/GFS_typedefs.F90: correct initialization of Model%fscav * Add FV3_GFS_v16_ras * Cld perts (NOAA-EMC#233) Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run. Also, addition of stochastic cloud perturbation and microphyiscs perturbations for SPPT. * upgrade OPAC aerosol with more advanced MERRA2 aerosol (NOAA-EMC#254) * changed .gitmodules to point to merra2 ccpp/physics * revert .gitmodule * update to Larissa version * add atmos_cube_sphere and ccpp/physics as submodules * add submodules of emc-2021-cloud * update ccpp/physics: remove CAPS version mp_nssl_2mom * ccpp/physics update: fix nssl mp reproducibility issue * Updating pointer to ccpp/physics. * Pointing to Christin's branch * Adding new suite for NSSL physics. * Updating suites to match HWT. * Updating gitmodules * Updating pointer to atmos_cubed_sphere. Co-authored-by: Tim Supinie <tsupinie@ou.edu> Co-authored-by: shansun6 <48043606+shansun6@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: XiaqiongZhou-NOAA <48254930+XiaqiongZhou-NOAA@users.noreply.github.com> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: AnningCheng-NOAA <48297505+AnningCheng-NOAA@users.noreply.github.com> Co-authored-by: Jili Dong <jili.dong@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run.
Also, addition of stochastic cloud perturbation and Micropyiscs perturbations for SPPT.
Is a change of answers expected from this PR?
No changes are expected with regression tests, but stochastic phsics regression test answer does change due to using a local version of ffpack instead of the fftpack in splib.
Issue(s) addressed
ccpp_physics: Stochastic MP and cloud perturbations NCAR/ccpp-physics#553
stochastic_physics: Ocean stochastic physics and netCDF restarts NOAA-PSL/stochastic_physics#35
Testing
How were these changes tested?
testing of new science additions were tested with 1-degree coupled model ensemble forecasts out to 35-day
What compilers / HPCs was it tested with? All tests on hera with intel and GNU compuler.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
The cloud perturbations and microphhysics perturbations are not included in any RTs.
Have the ufs-weather-model regression test been run? Currently a subset of regression tests were run on hera with intel and GNU compliers
Yes, stochastic physics test will be changed due to using a local version of fftpack
I am waiting on code review before doing the full regression test suite.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?