Stochastic MP and cloud perturbations#553
Merged
Merged
Conversation
update from NCAR's master
merge with NCAR fork
update with authoritative repo
Update with NCAR fork
get latest updates from master
pjpegion
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
ClaraDraper-NOAA
approved these changes
Feb 8, 2021
9 tasks
climbfuji
requested changes
Mar 5, 2021
climbfuji
requested changes
Mar 18, 2021
climbfuji
approved these changes
Mar 18, 2021
grantfirl
reviewed
Mar 18, 2021
| ! perturb cld cover | ||
| if (pert_clds) then | ||
| do i=1,im | ||
| tmp_wt= -1*log( ( 2.0 / ( sppt_wts(i,38) ) ) - 1 ) |
Collaborator
There was a problem hiding this comment.
Will the hard-coded '38' index cause any future problems?
Contributor
Author
There was a problem hiding this comment.
It may in the future, but for L64 and L127 this works.
grantfirl
approved these changes
Mar 18, 2021
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks OK to me. Approved.
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
* ccpp physics: Fix RAP (Grell Freitas) decomp b4b issues; moninshoc.meta missing mfpbl.f dependency * dycore: Fixes failure of decomposition test for regional case with nrows_blend > 0. Also fixes a bug where nrows_blend=1 caused a crash. Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Jun.Wang <Jun.Wang@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR references ufs-weather-model issue ufs-community/ufs-weather-model#371
Updates include cloud fraction perturbations, currently only available with RRTMG radiation, stochastic perturbations to all microphysics tracers, not just specific humidity, and option to turn off radiative heating perturbations for SPPT.
All of these are controlled with namelist options, and the default is the all new features are off.