Consistent names in the meta files#124
Closed
ShanSunNOAA wants to merge 2 commits into
Closed
Conversation
… changes in output.
Collaborator
|
The commit history looks good now. I would have preferred using |
Collaborator
Author
|
Hi Dom,
I see your point. Although names of ice, lnd and wat are used in CCPP, they
were ice, land and ocean in GFS_typedefs. I will replace wat by water only
in GFS_typedefs.
Thanks,
Shan
…On Wed, May 27, 2020 at 4:44 PM Dom Heinzeller ***@***.***> wrote:
The commit history looks good now. I would have preferred using cmm_water
instead of cmm_wat (same for all others), because ice and land are
spelled out. But I will defer this decision to others.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#124 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVX4YFMJWN7Z3GFSRNLRTWJTXANCNFSM4NMRZ4NA>
.
|
Collaborator
Thanks - and GFS_typedefs.meta (in the square brackets only = the local names), please. |
Collaborator
Author
|
Done. Please let me know if you have any suggestions.
Thanks,
Shan
…On Wed, May 27, 2020 at 4:53 PM Dom Heinzeller ***@***.***> wrote:
Hi Dom, I see your point. Although names of ice, lnd and wat are used in
CCPP, they were ice, land and ocean in GFS_typedefs. I will replace wat by
water only in GFS_typedefs. Thanks, Shan
… <#m_3522275578139132738_>
Thanks - and GFS_typedefs.meta (in the square brackets only = the local
names), please.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#124 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVVV54UN6QB4F5TTKRDRTWKXLANCNFSM4NMRZ4NA>
.
|
Collaborator
|
@shansun6 is this PR still applicable after the flake changes are merged (#141 and PRs listed in there)? |
Collaborator
Author
|
Hi Dom,
What should I do here? Could you give me some options? Thanks,
Shan
…On Wed, Jul 15, 2020 at 2:01 PM Dom Heinzeller ***@***.***> wrote:
@shansun6 <https://github.com/shansun6> is this PR still applicable after
the flake changes are merged (#141
<#141> and PRs listed in there)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#124 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVUKXU5Y64ZJ7ER32IDR3YDIDANCNFSM4NMRZ4NA>
.
|
Collaborator
I am just wondering if this PR should still be merged or closed, given that a consensus was reached on how to best implement flake. |
Collaborator
Author
|
It appears that flake cannot run with s2s - the coupled model crashed even
when flake is turned off. There are email exchanges among Yihua, Moorthi
and Jun today, trying to figure it out. I guess flake needs to work with
the coupled model before this PR can be merged? Jun should know more on
this.
Thanks,
Shan
…On Wed, Jul 15, 2020 at 2:45 PM Dom Heinzeller ***@***.***> wrote:
Hi Dom, What should I do here? Could you give me some options? Thanks, Shan
… <#m_-758419076718281365_>
I am just wondering if this PR should still be merged or closed, given
that a consensus was reached on how to best implement flake.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#124 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVXI5H2BU5HYJNAZKR3R3YINBANCNFSM4NMRZ4NA>
.
|
Collaborator
|
The corresponding ccpp-physics PR NCAR/ccpp-physics#456 was closed in agreement with @shansun6. Please close this PR, too. |
LarissaReames
pushed a commit
to LarissaReames/fv3atm
that referenced
this pull request
Nov 17, 2023
* add check on eta levels to ensure their monotonicity * update Jili Dong's ak/bk external input to - use the FMS ascii_read (single read/broadcast) - error check input to ensure the proper number of levels present * added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing standard/long names to be consistent with variable names. No changes in output.
It corresponds to ccpp PR #456.