Consistent names in the meta files#456
Closed
ShanSunNOAA wants to merge 2 commits into
Closed
Conversation
ShanSunNOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
Collaborator
|
@shansun6 is this PR still necessary based on the way the FLake model was implemented? |
Collaborator
Author
|
Hi Dom,
Please close it for now. We might follow up with a new PR if necessary now
that the flake model is in.
Thanks,
Shan
…On Wed, Aug 26, 2020 at 8:30 AM Dom Heinzeller ***@***.***> wrote:
@shansun6 <https://github.com/shansun6> is this PR still necessary based
on the way the FLake model was implemented?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#456 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVWC65KIM57XBAYNTKTSCUL6ZANCNFSM4NMPZ2YA>
.
|
Collaborator
|
Highly productive morning, getting rid of several open PRs ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing standard/long names to be consistent with variable names. No changes in output.