Chsp physics update, global latlon grid, post changes and CCN-IN followup bugfix#104
Conversation
> > Co-authored-by: Jongil Han <jingil.han@noaa.gov>
…frey Whitaker Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>
Co-authored-by: Jongil Han <jongil.han@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
Co-authored-by: Grant Firl <grantf@ucar.edu>
…physics/physics/sfc_diff.f; updates for CCPP
CHSP latlon post: bugfixes and missing updates for CCPP
| Stateout%gt0, Stateout%gu0, Stateout%gv0, rain1, & | ||
| kbot, ktop, kcnv, islmsk, Statein%vvl, ncld, & | ||
| Diag%hpbl, hflx, evap, ud_mf, dt_mf, cnvw, cnvc, & | ||
| Diag%hpbl, hflxq, evapq, ud_mf, dt_mf, cnvw, cnvc,& |
There was a problem hiding this comment.
I am sure you have a reason for it, but I don't understand why this change is only for shalcnv, but not for samfshalcnv (or any other convection scheme)?
There was a problem hiding this comment.
It is because only shalcnv among convection schemes needs kinematic sensible heat flux (hflx) and latent heat flux (evap) for the cloud base mass flux. The other convection schemes do not use hflx & evap.
There was a problem hiding this comment.
Thanks, got it! We need to make sure - I'll create an issue to check - that none of the additional convection schemes in CCPP that are not in IPD use hflx & evap.
There was a problem hiding this comment.
Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>
| use machine, only: kind_phys | ||
| real(kind=kind_phys),parameter :: pgwd = 1._kind_phys | ||
| real(kind=kind_phys),parameter :: pgwd4 = 1._kind_phys | ||
| logical debugprint = .false. |
There was a problem hiding this comment.
See comment here: NCAR/ccpp-physics#440 (comment)
|
Final RT passed, code is ready for commit after review. Thanks |
JongilHan66
left a comment
JongilHan66
left a comment
There was a problem hiding this comment.
Changes for the canopy heat storage parameterization (CHSP), thermal roughness length, and increased background diffusivity and mixing length in the inversion layers look fine.
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I did raise one question that remains unanswered (https://github.com/NOAA-EMC/fv3atm/pull/104/files?file-filters%5B%5D=.F90&file-filters%5B%5D=.f&file-filters%5B%5D=.f90&file-filters%5B%5D=.meta&file-filters%5B%5D=dotfile#r414570311), but this shouldn't delay the commit. Otherwise this is a bunch of important changes!
|
Jongil's answer: It is because only shalcnv among convection schemes need
kinematic sensible heat flux (hflx) and latent heat flux (evap) for the
cloud base mass flux. The other convection schemes do not use hflx & evap.
…On Tue, Apr 28, 2020 at 9:52 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** approved this pull request.
I did raise one question that remains unanswered (
https://github.com/NOAA-EMC/fv3atm/pull/104/files?file-filters%5B%5D=.F90&file-filters%5B%5D=.f&file-filters%5B%5D=.f90&file-filters%5B%5D=.meta&file-filters%5B%5D=dotfile#r414570311),
but this shouldn't delay the commit. Otherwise this is a bunch of important
changes!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#104 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKTNYSURXHGTX27W2TRO3NSHANCNFSM4MNLI66Q>
.
|
DeniseWorthen
left a comment
DeniseWorthen
left a comment
There was a problem hiding this comment.
Looks great. All my changes are present as expected.
…ertAerosols Gf radiation update revert aerosols
GF_Tune_Oct2021
6 participants
In the commit:
Related PRs:
ccpp/physics #440
#104
NEMS #55
ufs-weather-model #108